Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastCS Eiger: Allow setting the photon energy and other MX settings #532

Open
DominicOram opened this issue Aug 19, 2024 · 2 comments
Open

Comments

@DominicOram
Copy link
Contributor

When arming the Eiger you need to provide the photon energy and a number of other metadata parameters (https://github.com/DiamondLightSource/dodal/blob/46132f0e066debaf906c1a80dcefca175b3f5c01/src/dodal/devices/eiger.py#L224). As part of #528 the signals were put in to do this but it still needs to be done as part of the arm of the eiger.

Acceptance Criteria

  • When arming the eiger the metadata is set
@coretl
Copy link
Collaborator

coretl commented Aug 20, 2024

Can we do this in the plan as bps.mv commands rather than putting this in arm? I was trying to restrict prepare to things that are common to all detectors, that are needed for the triggering system to know about, rather than expanding it to everything

@DominicOram
Copy link
Contributor Author

Can we do this in the plan as bps.mv commands rather than putting this in arm? I was trying to restrict prepare to things that are common to all detectors, that are needed for the triggering system to know about, rather than expanding it to everything

See comment at #528 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants