Logging utils no longer exported

[DiamondJoseph]

No description provided.

[coretl]

Which ones in particular?

[DiamondJoseph]

dodal was using

from ophyd_async.log import (
    DEFAULT_DATE_FORMAT,
    DEFAULT_FORMAT,
    DEFAULT_LOG_COLORS,
    ColoredFormatterWithDeviceName,
)
from ophyd_async.log import logger as ophyd_async_logger

None of these are exported in 0.5.0

ophyd_async_logger was used to configure the logging level of ophyd-async and set it as part of a logging hierarchy
The rest were used to construct a DEFAULT_FORMATTER to make logging consistent between all loggers there (graylog, file, stdout)

[coretl]

@abbiemery any opinions?

[DiamondJoseph]

While I'm in this issue, other things that dodal was using but that are no longer private:

merge_gathered_dicts, SoftConverter,

[DiamondJoseph]

class ApertureConverter(SoftConverter):
        # Ophyd-async #311 should add a default converter for dataclasses to do this
        def reading(
            self, value: SingleAperturePosition, timestamp: float, severity: int
        ) -> Reading:
            return Reading(
                value=asdict(value),
                timestamp=timestamp,
                alarm_severity=-1 if severity > 2 else severity,
            )

SoftConverter was being overriden to allow returning a SingleAperturePosition, a dataclass, which I believe would not actually be allowed as it's not returning one of the types allowed by DataKey? I can only assume this was required previously for it to work and it was working.

@dataclass
class SingleAperturePosition:
    name: str
    GDA_name: str
    radius_microns: float | None
    location: ApertureFiveDimensionalLocation

merge_gathered_dicts was being used to gather softsignal metadata for devices

[coretl]

@DominicOram says that for this individual use case "if it is causing pain, then it's ok to explode it out into multiple signals", which should mean you don't need SoftConverter or merge_gathered_dicts, and it won't be broken by #310