We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signal
SignalBackend
We should alter the kwargs of Signal/SignalBackend such that
kwargs
datatype
__init__
EpicsSignalBackend
SignalBackend.connect
connect
arg
kwarg
# Signal def __init__( self, *, backend: Optional[SignalBackend[T]] = None, datatype: Optional[SignalDataType] = None, timeout: Optional[float] = DEFAULT_TIMEOUT, name: str = "", ) -> None: #: If set, then the datatype of the value is guaranteed to be this type self.datatype = datatype .... async def connect( self, *, mock=False, timeout=DEFAULT_TIMEOUT, force_reconnect: bool = False, backend: Optional[SignalBackend[T]] = None, ): .... # Signal backend @abstractmethod async def connect( self, *, datatype: Optional[type] = None, timeout: float = DEFAULT_TIMEOUT ): ....
Part of this change will be getting rid of conversion in mock signal backend.
Originally posted by @coretl in #310 (comment)
The text was updated successfully, but these errors were encountered:
a30d8cd
Successfully merging a pull request may close this issue.
We should alter the
kwargs
ofSignal
/SignalBackend
such thatSignal
takes an optionaldatatype
in__init__
and do some validation on itEpicsSignalBackend
takesdatatype
in__init__
SignalBackend.connect
now takesdatatype
insteadSignal
andSignalBackend
__init__
andconnect
arg
tokwarg
inference is preventedPart of this change will be getting rid of conversion in mock signal backend.
Originally posted by @coretl in #310 (comment)
The text was updated successfully, but these errors were encountered: