Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: clean up dependencies left from ophyd v2 #1190

Merged
merged 5 commits into from
Jul 19, 2024

Conversation

mrakitin
Copy link
Member

As discussed in Slack with @coretl.

@mrakitin mrakitin requested a review from coretl May 15, 2024 14:01
@coretl
Copy link
Collaborator

coretl commented May 15, 2024

The directory ophyd/v2 is still there, I thought we deleted that! Please can you delete that as part of this PR?

@mrakitin
Copy link
Member Author

Done! I've removed the v2/ directory and made some touch ups in the code/docs.

@mrakitin
Copy link
Member Author

@coretl, it's ready for re-review!

@mrakitin mrakitin requested a review from tacaswell May 17, 2024 15:32
@prjemian
Copy link
Contributor

@mrakitin : Can this PR be merged? It's approved.

@mrakitin
Copy link
Member Author

I'll rebase and merge, thanks for the reminder, @prjemian!

@tacaswell tacaswell merged commit 9c77d86 into bluesky:master Jul 19, 2024
9 checks passed
@mrakitin mrakitin deleted the cln-dependencies branch July 19, 2024 21:59
@mrakitin
Copy link
Member Author

Thanks, @tacaswell!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants