-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change underlying TPS
struct
#122
Comments
The time for operations is of course unchanged, but the allocations are now significantly faster:
|
Speed differences for the benchmark without @FastGTPSA appears negligible, including not using the flexible array members. However Julia memory usage now stays completely sane. Also, I tested using Vectors of these new structs and feeding that straight into the C (instead of creating temporary array of pointers as I was) and that appears to be working too. |
Fixed in #123 |
This will be a lot of work, but I think is worth it
#121
I think by putting the ctors in Julia and using jl_malloc INSIDE Julia, there could be a massive speedup (simple testing shows so).
This requires removing the flexible array members from the tpsa structs in C and replacing them with pointers. There is a bit of a slowdown here but I think using everything inside Julia will make up for it
The text was updated successfully, but these errors were encountered: