Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better TPSA print #44

Closed
1 of 2 tasks
DavidSagan opened this issue Dec 18, 2023 · 4 comments
Closed
1 of 2 tasks

Better TPSA print #44

DavidSagan opened this issue Dec 18, 2023 · 4 comments

Comments

@DavidSagan
Copy link
Member

DavidSagan commented Dec 18, 2023

  • The "I" column has got to go.
  • Do not print coefficients whose magnitude is less than eps where eps is a global that users can set and whose default value is small (like 1e-10).
@mattsignorelli
Copy link
Contributor

@DavidSagan Ok, take a look at the current format and let me know

@mattsignorelli
Copy link
Contributor

One change could be to use the sparse monomial order indexing ( 1 0 1 would be 1=>1, 3=>1) for the exponents column. I think this might be a lot cleaner for when the GTPSA has a number of variables above say 10, or we could just default to it

@mattsignorelli
Copy link
Contributor

Sparse monomial indexing added, printing also uses PrettyTables.jl which takes care of when it might go off the screen. I don't think I will add. the eps, because I'm hesitant to add a non constant global and there's some other reasons too we can discuss tomorrow. So the printing should be complete now

@mattsignorelli
Copy link
Contributor

Sparse monomial format will be used for printing when nv + np > 6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants