Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vars(d) throws error #90

Closed
DavidSagan opened this issue Feb 19, 2024 · 7 comments
Closed

vars(d) throws error #90

DavidSagan opened this issue Feb 19, 2024 · 7 comments

Comments

@DavidSagan
Copy link
Member

The documentation says that vars() should work but it does not:

julia> x = vars()
ERROR: MethodError: no method matching vars()

But x = vars(::Descriptor) does work

@mattsignorelli
Copy link
Contributor

I am not seeing this bug on the current stable release (v0.2.1) or the most recent dev version

@DavidSagan DavidSagan changed the title vars() throws error vars(d) throws error Feb 19, 2024
@DavidSagan
Copy link
Member Author

DavidSagan commented Feb 19, 2024

Sorry I did not update properly. Now vars() works but:

julia> x = vars(d)
ERROR: MethodError: no method matching vars(::Descriptor)

Should this not work?

@DavidSagan
Copy link
Member Author

Also what is the status of the default descriptor?

@mattsignorelli
Copy link
Contributor

mattsignorelli commented Feb 19, 2024

Yes, this is a new change. For consistency with the rest of the constructors TPS/ComplexTPS/mono, it is now a kwarg use so

x = vars(use=d)

use could also be a TPS or ComplexTPS. Tomorrow I will push a new stable release with docs updated and many bug fixes I found

@DavidSagan
Copy link
Member Author

OK I wait.

@mattsignorelli
Copy link
Contributor

I also found a C bug in cutord that leads to silent memory corruption, this was reported upstream to Laurent but my push tomorrow has a barrier to prevent this from happening.

There is a global GTPSA.desc_current that is set every time the user creates a new Descriptor, but could also be set manually. This I believe is documented

@mattsignorelli
Copy link
Contributor

v0.2.2 incoming now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants