Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window_Windows::init() does not allow to control initial visibility and closeability #57

Open
ManuelKugelmann opened this issue Nov 24, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@ManuelKugelmann
Copy link

ManuelKugelmann commented Nov 24, 2021

Maybe change the signature toBool Window_WindowsX::init(bool visible, bool closeable)and add

if (!closeable)
{
    m_windowClass.style |= CS_NOCLOSE;
}

and

setVisibility(visible);

@violinyanev
Copy link
Member

Hi @ManuelKugelmann ! That's because these classes are not meant to be called externally. All of these settings are controlled over the display config, and we intend to keep it this way - for the sake of user friendliness. But if you provide us some more details what you want to achieve/do we can reconsider (see also my other replies)

@ManuelKugelmann
Copy link
Author

Hi @violinyanev is visibility and closeablity now controllable via the config? I did not see much new there, but I didn't look too deep this time (just wanted to do a quick update of my ramses Spout & Unity3D Plugin and thought I'd report a few of the stumbling blocks).

When I'm using a ramses renderer inside the Plugin, I usually want it's window stay hidden (right from the start, without a flicker) and only see it for debugging purposes - in this case it should not be closeable by the user to not interfere with the plugin operation.

@violinyanev
Copy link
Member

Will see what we can do!

@violinyanev violinyanev added the enhancement New feature or request label Nov 28, 2021
@violinyanev
Copy link
Member

Hi @ManuelKugelmann ! Would it be fine to make also this class extensible (similar to WGL_Context) and you can override it in your code with whatever logic you need? If you don't want to have code dupes with the built-implementation of init(), we could also split some parts of it into smaller methods that you can call from your code. Which parts do you need?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants