Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usb common #75

Merged
merged 4 commits into from
Sep 9, 2023
Merged

Usb common #75

merged 4 commits into from
Sep 9, 2023

Conversation

fysnet
Copy link
Collaborator

@fysnet fysnet commented Sep 8, 2023

This catches (possible) errors in the Bochrc file when declaring USB port options.
The first catches when the user defines a port twice. This will PANIC.

usb_ohci: port1=mouse, options1="speed:low, model:m228"
usb_ohci: port1=keyboard, options1="speed:low"

The second catches a possible error if the user copy/pastes a line and forgets to update the options# part as in the example below.

usb_ohci: port1=tablet, options1="speed:low"
usb_ohci: port2=disk, options1="speed:full, path:hdd.img"

However, this will not PANIC since the following is completely legal:

usb_ohci: port2=disk
usb_ohci: options2="speed:full"
usb_ohci: options2="path:hdd.img"

This will simply display an error on the Bochs console window.

@fysnet fysnet marked this pull request as ready for review September 8, 2023 23:00
@stlintel stlintel merged commit fae8e69 into bochs-emu:master Sep 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants