Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve default device detection #77

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

fysnet
Copy link
Collaborator

@fysnet fysnet commented Sep 13, 2023

This improves the detection of the default speed of a device when given in bochsrc.

It will first get the max speed of the port given. For example, uhci and ohci will return FULL, ehci will return HIGH.
xHCI will return SUPER if the port is a super-speed port, else it will return HIGH.

Then it will compare this with the max speed allowed for that device, returning the highest common speed.

Of course, if the speed option is given, the above is overwritten by the specified speed.

Both checks are still performed on the result.

  1. does device allow the result speed?
  2. does the controller allow the result speed?

@fysnet fysnet marked this pull request as ready for review September 14, 2023 00:00
@stlintel stlintel merged commit b46fc68 into bochs-emu:master Sep 14, 2023
1 check passed
@fysnet fysnet deleted the usb_common branch September 15, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants