Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equation 3 (Quantize function) implemented correctly? #18

Open
Saadmaghani opened this issue May 6, 2023 · 0 comments
Open

Equation 3 (Quantize function) implemented correctly? #18

Saadmaghani opened this issue May 6, 2023 · 0 comments

Comments

@Saadmaghani
Copy link

Hi,

Eq 3 in the paper shows that the rounding is applied on x/sigma(k) but what I see in the implementation is:
tf.round(x * SCALE) / SCALE in line 37 of src/Quantize.py:Q
Shouldn't it be: tf.round(x / SCALE) * SCALE?

Eq 3 from paper:
Screenshot 2023-05-06 at 6 27 37 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant