Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Scan QR on mobile does not work (also UI bug) #84

Open
joedavison opened this issue Jun 17, 2023 · 4 comments · May be fixed by #97
Open

Bug - Scan QR on mobile does not work (also UI bug) #84

joedavison opened this issue Jun 17, 2023 · 4 comments · May be fixed by #97
Assignees
@leobz
Labels
bug Something isn't working

Comments

@joedavison
Copy link
Member

Screenshot 2023-06-17 at 2 49 34 AM
@leobz leobz added the bug Something isn't working label Jun 17, 2023
@leobz leobz self-assigned this Jun 26, 2023
@leobz
Copy link
Member

leobz commented Jun 26, 2023 •
edited
Loading

Info note: Remote debug using Android device

The HTTP seems to be the problem -> nimiq/qr-scanner#31

I am going to enable HTTPS locally to check that

Image

@joedavison
Copy link
Member Author

joedavison commented Jun 26, 2023 •
edited
Loading

It seems like this might be fixed in production since there is https

@leobz
Copy link
Member

leobz commented Jun 27, 2023

Test with HTTPS locally:

image

@leobz leobz linked a pull request Jun 27, 2023 that will close this issue
84 bug scan qr on mobile does not work also UI bug #97
Open
@leobz
Copy link
Member

leobz commented Jun 27, 2023

It seems like this might be fixed in production since there is https

But not in alpha.bookmark.org right?
I can add an nginx server + let's encrypt in the docker-compose to automatize and add SSL support in any droplet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leobz leobz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

84 bug scan qr on mobile does not work also UI bug bookmark-org/bookmark
2 participants
@joedavison @leobz