Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Error "Domain not allowed" for substack.com #90

Open
joedavison opened this issue Jun 21, 2023 · 1 comment · May be fixed by #100
Open

Bug: Error "Domain not allowed" for substack.com #90

joedavison opened this issue Jun 21, 2023 · 1 comment · May be fixed by #100
Labels
bug Something isn't working

Comments

@joedavison
Copy link
Member

Screenshot 2023-06-21 at 1 50 07 PM

observe:

substack.com is not present in /priv/static/blocked_domains.txt

archive a link to substack page, e.g. https://whyisthisinteresting.substack.com/p/the-platinum-photography-edition

application error messages indicates domain not allowed
@leobz leobz added the bug Something isn't working label Jun 29, 2023
@leobz leobz linked a pull request Jun 29, 2023 that will close this issue
Valid domains are not allowed: Fix + Testing #100
Open
@leobz
Copy link
Member

leobz commented Jun 29, 2023

Yes, the problem was ack.com domain inside the blocked_domains.txt. I also had issues with pages that had the fandom.com subdomain also included there.

The real problem was here

 blocked_domains
    |> Enum.find(&String.contains?(url, &1))

I solved the problem in this PR #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Valid domains are not allowed: Fix + Testing bookmark-org/bookmark
2 participants
@joedavison @leobz