Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check list among the nodes #698

Open
Charleslee522 opened this issue Nov 9, 2018 · 5 comments
Open

Check list among the nodes #698

Charleslee522 opened this issue Nov 9, 2018 · 5 comments
Assignees
Labels

Comments

@Charleslee522
Copy link
Member

Charleslee522 commented Nov 9, 2018

All nodes must check follows among the validators

  • Initial Balance
  • Genesis Account
  • Common Account
  • Transactions Limit
  • Operations Limit
  • Timeouts
  • Unfreezing period
  • and so on...
@Charleslee522 Charleslee522 self-assigned this Nov 9, 2018
@spikeekips
Copy link
Contributor

@Charleslee522 I have question. Most of values must be same within nodes, but if some nodes have different value like 'Timeouts`, how does the node react to?

@Charleslee522
Copy link
Member Author

@spikeekips The node does not check and react yet. So some side effect could be occurred in consensus :)
Therefore, I think these config value should be checked on booting.

@spikeekips
Copy link
Contributor

@Charleslee522 So if different, exclude the different node from consensus?

@Charleslee522
Copy link
Member Author

@spikeekips It should be.

@Geod24
Copy link
Contributor

Geod24 commented Nov 22, 2018

This is why I originally advocated against exposing so many consensus-critical settings through the command line. At the end of the day, no one is going to change them because that would result in errors in consensus.

Some of them are useful for other purpose (e.g. unfreezing period for testing), but we could find another way (or not expose the argument / document it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants