Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployProtocolClients should not deploy client proxy anymore #761

Closed
zajck opened this issue Aug 8, 2023 · 0 comments · Fixed by #776
Closed

deployProtocolClients should not deploy client proxy anymore #761

zajck opened this issue Aug 8, 2023 · 0 comments · Fixed by #776
Assignees
Labels
enhancement New feature or request

Comments

@zajck
Copy link
Member

zajck commented Aug 8, 2023

Since #703 was merged, voucher proxy is deployed directly from the protocol.
This makes proxy deployment as part of the deployment script redundant.

Lines

// Deploy Protocol Client proxy contracts
const protocolClientProxies = await deployProtocolClientProxies(protocolClientBeacons, maxPriorityFeePerGas);
// Cast the proxies to their implementation interfaces ?? ToDo: what is this even needed?
const protocolClients = await castProtocolClientProxies(protocolClientProxies);
should be removed to prevent unnecessary transactions during the protocol deployment or upgrade.

@zajck zajck added the enhancement New feature or request label Aug 8, 2023
@zajck zajck self-assigned this Aug 14, 2023
@zajck zajck closed this as completed in #776 Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant