Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore e2e tests on ubuntu-latest image #607

Open
levalleux-ludo opened this issue Nov 17, 2023 · 0 comments
Open

restore e2e tests on ubuntu-latest image #607

levalleux-ludo opened this issue Nov 17, 2023 · 0 comments

Comments

@levalleux-ludo
Copy link
Member

levalleux-ludo commented Nov 17, 2023

e2e tests have been failing the 16th/17th of November

Error is revealed when running the meta-tx.test.ts test

FAIL e2e/tests/meta-tx.test.ts
  ● Test suite failed to run

    e2e/tests/meta-tx.test.ts:30:30 - error TS2307: Cannot find module '../../contracts/protocol-contracts/scripts/domain/EvaluationMethod' or its corresponding type declarations.

    30 import EvaluationMethod from "../../contracts/protocol-contracts/scripts/domain/EvaluationMethod";
                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    e2e/tests/meta-tx.test.ts:31:23 - error TS2307: Cannot find module '../../contracts/protocol-contracts/scripts/domain/TokenType' or its corresponding type declarations.

    31 import TokenType from "../../contracts/protocol-contracts/scripts/domain/TokenType";
                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

However the cause of this error can be found before in the logs:
Npm postinstall step is failing when preparing the test environment:

> core-components@1.0.0 e2e:suite:default
> ./e2e/run-e2e-suite.sh

Install protocol and dependencies...
npm WARN deprecated ganache-core@2.13.2: ganache-core is now ganache; visit https://trfl.io/g7 for details
npm WARN deprecated ganache-core@2.13.2: ganache-core is now ganache; visit https://trfl.io/g7 for details
npm WARN skipping integrity check for git dependency ssh://git@github.com/ProjectOpenSea/seaport.git 
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated uuid@2.0.1: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated testrpc@0.0.1: testrpc has been renamed to ganache-cli, please use this package from now on.
npm WARN deprecated request-promise-native@1.0.9: request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated debug@3.2.6: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated debug@3.2.6: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated @ensdomains/ens@0.4.5: Please use @ensdomains/ens-contracts
npm WARN deprecated @ensdomains/resolver@0.2.4: Please use @ensdomains/ens-contracts
npm ERR! code 1
npm ERR! path /home/runner/work/core-components/core-components/contracts/node_modules/postinstall-postinstall
npm ERR! command failed
npm ERR! command sh -c -- node ./run.js
npm ERR! error This project's package.json defines "packageManager": "yarn@npm@8.[11](https://github.com/bosonprotocol/core-components/actions/runs/6903347318/job/18786355111#step:10:12).0". However the current global version of Yarn is 1.22.21.
npm ERR! 
npm ERR! Presence of the "packageManager" field indicates that the project is meant to be used with Corepack, a tool included by default with all official Node.js distributions starting from 16.9 and [14](https://github.com/bosonprotocol/core-components/actions/runs/6903347318/job/18786355111#step:10:15).19.
npm ERR! Corepack must currently be enabled by running corepack enable in your terminal. For more information, check out https://yarnpkg.com/corepack.
npm ERR! node:child_process:935
npm ERR!     throw err;
npm ERR!     ^
npm ERR! 
npm ERR! Error: Command failed: yarn run postinstall
npm ERR! error This project's package.json defines "packageManager": "yarn@npm@8.11.0". However the current global version of Yarn is 1.22.21.
npm ERR! 
npm ERR! Presence of the "packageManager" field indicates that the project is meant to be used with Corepack, a tool included by default with all official Node.js distributions starting from [16](https://github.com/bosonprotocol/core-components/actions/runs/6903347318/job/18786355111#step:10:17).9 and 14.[19](https://github.com/bosonprotocol/core-components/actions/runs/6903347318/job/18786355111#step:10:20).
npm ERR! Corepack must currently be enabled by running corepack enable in your terminal. For more information, check out https://yarnpkg.com/corepack.
npm ERR!

Problem has been worked around using the previous version (20.02) of the ubuntu image for the pipeline.
(

runs-on: ubuntu-20.04
)
However, a proper fix should be found to avoid staying stuck on this version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant