Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect the subgraph url (for 3rd party clients) on our DNS, so that they are not impacted when we change provider #734

Open
levalleux-ludo opened this issue May 16, 2024 · 0 comments

Comments

@levalleux-ludo
Copy link
Member

levalleux-ludo commented May 16, 2024

At the moment, the subgraph URL is set in core-sdk configuration, and used as is by all clients.
For instance:

"https://api.thegraph.com/subgraphs/name/bosonprotocol/polygon",

Problem is that we need to change the subgraph URL as TheGraph hosted service is getting deprecated soon.
That means every client will have to upgrade their configuration to keep alive.
The idea is to replace this url wirh a constant value (using our DNS, like https://subgraph-polygon-wc.bosonprotocol.io) that always redirect to our subgraph, whatever provider is used behind.

Different subdomain could be used for the different (2rd party) clients we have, so that a discrimination would be possible:

  • boson-dcl: https://subgraph-polygon-dcl.bosonprotocol.io, https://subgraph-ethereum-dcl.bosonprotocol.io
  • woocommerce: https://subgraph-polygon-wc.bosonprotocol.io, https://subgraph-ethereum-wc.bosonprotocol.io
  • a default subgraph (cheap / rate limited) to allow any other 3rd party clients to start easily until they deploy their own subgraph: https://subgraph-polygon.bosonprotocol.io, https://subgraph-ethereum.bosonprotocol.io

Note: the dApp and widgets may not need such an abstraction as we have full control over them: when we change the subgraph, we can upgrade them. IMHO, there is no need to define constant URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant