-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a way to show more details to an event #298
Comments
Wireframe for the UI design link: https://excalidraw.com/#json=zIGQ_UzEHFelbd0hsIZKT,ZkABIJCI4WR2_IYjnH2yYQ for the 1st iteration, I have only used |
it looks quite nice but i also want something which really shows ALL the properties of the event, especially those not handled otherwise. also, maybe we could split up the a11y icon into a nicer list somehow? |
would you share the properties we want to show here? also, I agree with you about splitting up the a11y icon, I'll find a way to show it. also, I need to figure out the appropriate layout for the component. |
by default we should at least show all properties that we can filter for and then somewhere else also all properties we don't show anywhere ese |
ok, then let me first implement the first iteration and then add the properties we are filtering for. to see how layouting can be improved. |
properties to display on the expanded event component, in the second iteration,
|
after researching about the effect of this feature on the user experience, I have reached to a point to continue by implementing it either as a It also can affect a11y, since some user may find it unpleasant to follow the shift in layout. so, the decision is to instead of injecting the details in the events row, when the user clicks or taps an event element (or on a link or a button) open a drawer/modal and show the properties. @kadhonn do you have any input? references: |
well, the two links you posted about cls are interesting but are only talking about unexpected layout shifts |
it talks about expected shifts under "User-initiated layout shifts" section of the first link. but, every layout shift has an effect on the UX and A11y, expected or unexpected. let me make sure it does not affect A11Y first, then UX second. and I'm guessing that a drawer or modal is more predictable than an expandable element in this scenario for a person who requires accessibility. since we are already using a drawer for filters, it may make more sense to stick to the current behaviour and not introduce new one (regarding the predictability of the navigation in a11y). it can also be a valid case to be discussed with the integriert studieren institute. I can also implement it and we can check it later with UX fellow against the personas. |
the expanding feature would be like this, did we mean to cover the whole row with an expanded event? event-detail.mp4 |
we talked in our daily today, our concerns at the moment are: white spaces, details that we want to embed in the element and a11y. |
in our meeting today we decided to keep the portotypes in separate branches so then we can work on them at the same time. |
we may need to consider extending the PictureProxy to have a functionality to request pictures in requested size. |
one a11y concerns for the Modal and Drawer prototypes is to prevent mouse or keyboard trap. |
some progress with the modal: next steps:
event-details-modal.mp4 |
what am I doing in the code that I'm not happy with is keeping the propeties with data attributes, I think it is not clean and there could be a better way. also, I can not append the eventHandler to the events that are loaded after the I press the "mehr laden" button. |
that should not be hard, and also we can do that easly in another step as enhancement |
i wrote in your PR already, it is better to prerender the modal/drawer content for each event but keep it invisible
why not? |
You are right, I'll prerender modal/drawer content. I'll implement the retriggering functionality. |
some progress with modal Screen.Recording.1403-02-02.at.00.45.30.mp4 |
event-details-modal-responsive.mp4 |
event details drawer event-detail-drawer.mp4 |
in the drawer, I prefer to have a two column layout instead of the single column I used for the modal. |
two column layout with drawer two-column-layout-drawer.mp4 |
Personally I prefer the two column layout. Possibly because that is what I used for museumsbahn-events.at as well. 😅 I think a modal always introduces a new layer in the UI that is not really needed. The drawer also has this kind of overlaying effect. With the two column layout the information stays "on the same level". I hope this makes sense. btw maybe a thing that should also be considered is what should happen when you get sent a link to a specific event from someone. Like: |
i also like the two-column layout more and to be honest, i am not quite sold on either drawer nor modal right now :/ and regarding direct-links, patzi and me a loong time ago decided they are not important for us, you should share the actual link of the event, so the source, not a boudicca link |
the latest update about this issue:
@kadhonn if I missed anything here, please let me know. |
TL;DR i think a singleview would be nice (altought SPA logic will break if a new doc loads when navigating) with focus on external open and other recomemndations for events on the bottom |
i think this is a good point about having a single-view: we can still make sure this single-view is accessible and has information about accessibility and people can share this single-view. this information can be lost when we only allow sharing the original url but i am not sure if a single view is the best solution while browsing our result list. if every time i want to see more information about this event i need to open a new tab this could get annoying. i still think in regards to usability the expanding event is the best option, because i can have multiple events open in parallel and it does not disrupt my scrolling. i think the main issue we had is that it creates gaps in our grid, maybe we can find simple solutions for that? |
latest update on the issue:
|
Currently we have much more information about events than we can show.
One way of making this additional info visible could be to on selecting an event or clicking on a details button to make this tile bigger and add addional fields that we want to display.
Coordinate with the UUSC Fellow for UX on what to show and how to do this.
The text was updated successfully, but these errors were encountered: