Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Inputs and Data Outputs are not being rendered #17

Open
SimonHe77wer opened this issue Jun 9, 2020 · 5 comments
Open

Data Inputs and Data Outputs are not being rendered #17

SimonHe77wer opened this issue Jun 9, 2020 · 5 comments
Labels
backlog Queued in backlog enhancement New feature or request

Comments

@SimonHe77wer
Copy link

SimonHe77wer commented Jun 9, 2020

I trie to create png from a bpmn file (created with eclipse bpmn modeler). The bpmn can be modeled with a single activity and a data object as input.
After creating a png with bpmn-to-image myBPMN:myBPMN.png the png does not show the data object.
When modeling a data object reference this reference shows in the final png, but not the data object itself.

Regards
Simon


Depends on bpmn-io/bpmn-js#951

@nikku
Copy link
Member

nikku commented Jun 9, 2020

Could you share a screenshot of your modeled diagram as well as the resulting BPMN file? That helps us to look into the issue.

@SimonHe77wer
Copy link
Author

image

`

<bpmn2:definitions xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:bpmn2="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" xmlns:di="http://www.omg.org/spec/DD/20100524/DI" id="Definitions_1" exporter="org.eclipse.bpmn2.modeler.core" exporterVersion="1.5.1.Final-v20190425-2005-B1">
<bpmn2:process id="Process_1" name="Process 1" isExecutable="false">
<bpmn2:ioSpecification id="InputOutputSpecification_3">
<bpmn2:inputSet id="InputSet_3" name="Input Set 3"/>
<bpmn2:outputSet id="OutputSet_3" name="Output Set 3"/>
</bpmn2:ioSpecification>
<bpmn2:laneSet id="LaneSet_1" name="Lane Set 1">
<bpmn2:lane id="Lane_1" name="Lane 1">
bpmn2:flowNodeRefTask_1</bpmn2:flowNodeRef>
bpmn2:flowNodeRefTask_2</bpmn2:flowNodeRef>
bpmn2:flowNodeRefStartEvent_1</bpmn2:flowNodeRef>
bpmn2:flowNodeRefEndEvent_1</bpmn2:flowNodeRef>
</bpmn2:lane>
</bpmn2:laneSet>
<bpmn2:task id="Task_1" name="Task 1">
bpmn2:incomingSequenceFlow_2</bpmn2:incoming>
bpmn2:outgoingSequenceFlow_1</bpmn2:outgoing>
<bpmn2:ioSpecification id="InputOutputSpecification_1">
<bpmn2:dataInput id="DataInput_1" name="input1"/>
<bpmn2:dataInput id="DataInput_4" name="input2"/>
<bpmn2:inputSet id="InputSet_1" name="Input Set 1">
bpmn2:dataInputRefsDataInput_1</bpmn2:dataInputRefs>
bpmn2:dataInputRefsDataInput_4</bpmn2:dataInputRefs>
</bpmn2:inputSet>
<bpmn2:outputSet id="OutputSet_1" name="Output Set 1"/>
</bpmn2:ioSpecification>
<bpmn2:dataInputAssociation id="DataInputAssociation_1">
bpmn2:sourceRefDataObject_2</bpmn2:sourceRef>
bpmn2:targetRefDataInput_1</bpmn2:targetRef>
</bpmn2:dataInputAssociation>
</bpmn2:task>
<bpmn2:task id="Task_2" name="Task 2">
bpmn2:incomingSequenceFlow_1</bpmn2:incoming>
bpmn2:outgoingSequenceFlow_3</bpmn2:outgoing>
<bpmn2:ioSpecification id="InputOutputSpecification_2">
<bpmn2:dataInput id="DataInput_2" name="input1"/>
<bpmn2:inputSet id="InputSet_2" name="Input Set 2">
bpmn2:dataInputRefsDataInput_2</bpmn2:dataInputRefs>
</bpmn2:inputSet>
<bpmn2:outputSet id="OutputSet_2" name="Output Set 2"/>
</bpmn2:ioSpecification>
<bpmn2:dataInputAssociation id="DataInputAssociation_2">
bpmn2:sourceRefDataObjectReference_2</bpmn2:sourceRef>
bpmn2:targetRefDataInput_2</bpmn2:targetRef>
</bpmn2:dataInputAssociation>
</bpmn2:task>
<bpmn2:sequenceFlow id="SequenceFlow_1" sourceRef="Task_1" targetRef="Task_2"/>
<bpmn2:dataObject id="DataObject_2" name="Data Object 1"/>
<bpmn2:startEvent id="StartEvent_1" name="Start Event 1">
bpmn2:outgoingSequenceFlow_2</bpmn2:outgoing>
</bpmn2:startEvent>
<bpmn2:sequenceFlow id="SequenceFlow_2" sourceRef="StartEvent_1" targetRef="Task_1"/>
<bpmn2:endEvent id="EndEvent_1" name="End Event 1">
bpmn2:incomingSequenceFlow_3</bpmn2:incoming>
</bpmn2:endEvent>
<bpmn2:sequenceFlow id="SequenceFlow_3" sourceRef="Task_2" targetRef="EndEvent_1"/>
<bpmn2:dataObjectReference id="DataObjectReference_2" name="Data Object 1" dataObjectRef="DataObject_2"/>
</bpmn2:process>
<bpmndi:BPMNDiagram id="BPMNDiagram_1">
<bpmndi:BPMNPlane id="BPMNPlane_1">
<bpmndi:BPMNShape id="BPMNShape_Lane_1" bpmnElement="Lane_1" isHorizontal="true">
<dc:Bounds height="251.0" width="1130.0" x="210.0" y="260.0"/>
<bpmndi:BPMNLabel id="BPMNLabel_1" labelStyle="BPMNLabelStyle_1">
<dc:Bounds height="38.0" width="15.0" x="216.0" y="366.0"/>
</bpmndi:BPMNLabel>
</bpmndi:BPMNShape>
<bpmndi:BPMNShape id="BPMNShape_Task_1" bpmnElement="Task_1" isExpanded="true">
<dc:Bounds height="50.0" width="110.0" x="385.0" y="345.0"/>
<bpmndi:BPMNLabel id="BPMNLabel_2" labelStyle="BPMNLabelStyle_1">
<dc:Bounds height="15.0" width="37.0" x="421.0" y="362.0"/>
</bpmndi:BPMNLabel>
</bpmndi:BPMNShape>
<bpmndi:BPMNShape id="BPMNShape_Task_2" bpmnElement="Task_2" isExpanded="true">
<dc:Bounds height="50.0" width="110.0" x="600.0" y="345.0"/>
<bpmndi:BPMNLabel id="BPMNLabel_3" labelStyle="BPMNLabelStyle_1">
<dc:Bounds height="15.0" width="37.0" x="636.0" y="362.0"/>
</bpmndi:BPMNLabel>
</bpmndi:BPMNShape>
<bpmndi:BPMNShape id="BPMNShape_DataObject_1" bpmnElement="DataObject_2">
<dc:Bounds height="50.0" width="36.0" x="330.0" y="270.0"/>
<bpmndi:BPMNLabel id="BPMNLabel_5" labelStyle="BPMNLabelStyle_1">
<dc:Bounds height="15.0" width="74.0" x="311.0" y="320.0"/>
</bpmndi:BPMNLabel>
</bpmndi:BPMNShape>
<bpmndi:BPMNShape id="BPMNShape_StartEvent_1" bpmnElement="StartEvent_1">
<dc:Bounds height="36.0" width="36.0" x="262.0" y="412.0"/>
<bpmndi:BPMNLabel id="BPMNLabel_7" labelStyle="BPMNLabelStyle_1">
<dc:Bounds height="15.0" width="68.0" x="246.0" y="448.0"/>
</bpmndi:BPMNLabel>
</bpmndi:BPMNShape>
<bpmndi:BPMNShape id="BPMNShape_EndEvent_1" bpmnElement="EndEvent_1">
<dc:Bounds height="36.0" width="36.0" x="822.0" y="362.0"/>
<bpmndi:BPMNLabel id="BPMNLabel_9" labelStyle="BPMNLabelStyle_1">
<dc:Bounds height="15.0" width="65.0" x="808.0" y="398.0"/>
</bpmndi:BPMNLabel>
</bpmndi:BPMNShape>
<bpmndi:BPMNShape id="BPMNShape_DataObjectReference_1" bpmnElement="DataObjectReference_2">
<dc:Bounds height="50.0" width="36.0" x="440.0" y="440.0"/>
<bpmndi:BPMNLabel id="BPMNLabel_11">
<dc:Bounds height="15.0" width="74.0" x="421.0" y="490.0"/>
</bpmndi:BPMNLabel>
</bpmndi:BPMNShape>
<bpmndi:BPMNEdge id="BPMNEdge_SequenceFlow_1" bpmnElement="SequenceFlow_1" sourceElement="BPMNShape_Task_1" targetElement="BPMNShape_Task_2">
<di:waypoint xsi:type="dc:Point" x="495.0" y="370.0"/>
<di:waypoint xsi:type="dc:Point" x="547.0" y="370.0"/>
<di:waypoint xsi:type="dc:Point" x="600.0" y="370.0"/>
<bpmndi:BPMNLabel id="BPMNLabel_4"/>
</bpmndi:BPMNEdge>
<bpmndi:BPMNEdge id="BPMNEdge_DataInputAssociation_1" bpmnElement="DataInputAssociation_1" sourceElement="BPMNShape_DataObject_1" targetElement="BPMNShape_Task_1">
<di:waypoint xsi:type="dc:Point" x="348.0" y="320.0"/>
<di:waypoint xsi:type="dc:Point" x="348.0" y="370.0"/>
<di:waypoint xsi:type="dc:Point" x="385.0" y="370.0"/>
<bpmndi:BPMNLabel id="BPMNLabel_6"/>
</bpmndi:BPMNEdge>
<bpmndi:BPMNEdge id="BPMNEdge_SequenceFlow_2" bpmnElement="SequenceFlow_2" sourceElement="BPMNShape_StartEvent_1" targetElement="BPMNShape_Task_1">
<di:waypoint xsi:type="dc:Point" x="280.0" y="412.0"/>
<di:waypoint xsi:type="dc:Point" x="280.0" y="378.0"/>
<di:waypoint xsi:type="dc:Point" x="385.0" y="378.0"/>
<bpmndi:BPMNLabel id="BPMNLabel_8"/>
</bpmndi:BPMNEdge>
<bpmndi:BPMNEdge id="BPMNEdge_SequenceFlow_3" bpmnElement="SequenceFlow_3" sourceElement="BPMNShape_Task_2" targetElement="BPMNShape_EndEvent_1">
<di:waypoint xsi:type="dc:Point" x="710.0" y="370.0"/>
<di:waypoint xsi:type="dc:Point" x="766.0" y="370.0"/>
<di:waypoint xsi:type="dc:Point" x="766.0" y="380.0"/>
<di:waypoint xsi:type="dc:Point" x="822.0" y="380.0"/>
<bpmndi:BPMNLabel id="BPMNLabel_10"/>
</bpmndi:BPMNEdge>
<bpmndi:BPMNEdge id="BPMNEdge_DataInputAssociation_2" bpmnElement="DataInputAssociation_2" sourceElement="BPMNShape_DataObjectReference_1" targetElement="BPMNShape_Task_2">
<di:waypoint xsi:type="dc:Point" x="476.0" y="465.0"/>
<di:waypoint xsi:type="dc:Point" x="655.0" y="465.0"/>
<di:waypoint xsi:type="dc:Point" x="655.0" y="395.0"/>
<bpmndi:BPMNLabel id="BPMNLabel_12"/>
</bpmndi:BPMNEdge>
</bpmndi:BPMNPlane>
<bpmndi:BPMNLabelStyle id="BPMNLabelStyle_1">
<dc:Font name="arial" size="9.0"/>
</bpmndi:BPMNLabelStyle>
</bpmndi:BPMNDiagram>
</bpmn2:definitions>`

@nikku
Copy link
Member

nikku commented Jun 10, 2020

So the issue is that the Data Object is part of an IO specification.

Rendering IO Specification is, unfortunately, not supported by the tool yet. Upstream issue: bpmn-io/bpmn-js#951.

@nikku nikku changed the title Data Objects not visible Data Inputs and Data Outputs are not being rendered Jun 10, 2020
@nikku nikku added backlog Queued in backlog enhancement New feature or request labels Jun 10, 2020
@SimonHe77wer
Copy link
Author

Hi @nikku ,
thanks for your response. We found out that DataInput and DataOutput are rendered. This is not correct from a model perspective but works for us as intermediate solution.
Looking forward to the improvement :-)

Greetings
Simon

@o314
Copy link

o314 commented Apr 27, 2022

Here is another good example that's missing nowaday
5-2-2

Also consider, those annotations pipelined upto a db that indicate what comes in and out the db itself (may be not executable, but a good contrib during the modeling phase anyway)
5-3-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants