From daa66206c3b1c3359ea0bf664ab708a2bfbd8268 Mon Sep 17 00:00:00 2001 From: 121593 <5079173-121593@users.noreply.gitlab.com> Date: Sat, 18 Nov 2023 11:34:06 +0100 Subject: [PATCH] fix(apple): Add timeout to request Invalid auth with Apple causing the call to hang indefinitely --- src/Sender/PushMessageSender.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Sender/PushMessageSender.php b/src/Sender/PushMessageSender.php index d64feff..26983d8 100644 --- a/src/Sender/PushMessageSender.php +++ b/src/Sender/PushMessageSender.php @@ -15,6 +15,8 @@ class PushMessageSender implements PushMessagerSenderInterface { + const DEFAULT_TIMEOUT = 30; + /** * @var Client */ @@ -90,7 +92,7 @@ public function push(PushMessage $message, iterable $subscriptions): iterable $request = $this->requestBuilder->withGCMAuthentication($request, $auth['GCM']); } - $promises[$subscriptionHash] = $this->client->sendAsync($request) + $promises[$subscriptionHash] = $this->client->sendAsync($request, ['timeout' => self::DEFAULT_TIMEOUT]) ->then(function (ResponseInterface $response) use ($subscription) { return new PushResponse($subscription, $response->getStatusCode()); })