fix: Properly skip empty groups in Bubble, Pie and Treemap charts

bprusinowski · Apr 21, 2024 · 4a7098c · 4a7098c
1 parent 8fe962b
commit 4a7098c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/charts/BubbleChart.ts b/src/charts/BubbleChart.ts
@@ -78,7 +78,8 @@ export const getters = (
       // Skip groups with no data.
       return !(
         isNaN(group.r) ||
-        group.children?.reduce((acc, d) => (acc += d.r), 0) === 0
+        !group.children ||
+        group.children.reduce((acc, d) => (acc += d.r), 0) === 0
       );
     })
     .map((group) => {

diff --git a/src/charts/PieChart.ts b/src/charts/PieChart.ts
@@ -83,7 +83,8 @@ export const getters = (
       // Skip groups with no data.
       return !(
         isNaN(group.r) ||
-        group.children?.reduce((acc, d) => (acc += d.r), 0) === 0
+        !group.children ||
+        group.children.reduce((acc, d) => (acc += d.r), 0) === 0
       );
     })
     .map((group) => {

diff --git a/src/charts/TreemapChart.ts b/src/charts/TreemapChart.ts
@@ -107,7 +107,8 @@ export const getters = (
       // Skip groups with no data.
       return !(
         group.value === 0 ||
-        group.children?.reduce((acc, d) => (acc += d.value), 0) === 0
+        !group.children ||
+        group.children.reduce((acc, d) => (acc += d.value), 0) === 0
       );
     })
     .map((group) => {