-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW ONLY] Fix brackets issue #2872- "Windows: Brackets may fail to launch on a very clean OS image" #448
Comments
Comment by bchintx I still need to confirm that this merge module alone is sufficient. I need to build a clean Windows machine on which to test this. Unfortunately, the standard virtual machine images that we have for testing appear to already have the C runtime libraries installed. |
Comment by JeffryBooher @bchintx should you close this or maybe test it on a clean vm and see if it's actually needed? |
Comment by bchintx @JeffryBooher I've been meaning to build a new Windows machine to test this. Unfortunately, our VMs are not viable test platforms since they already have the C runtime libraries installed. |
Issue by bchintx
Thursday Feb 20, 2014 at 23:46 GMT
Originally opened as adobe#424
Fix brackets issue #2872- "Windows: Brackets may fail to launch on a very clean OS image"
Adds Microsoft C runtime library merge module to the WiX script used to produce the Windows installer .msi.
bchintx included the following code: https://github.com/adobe/brackets-shell/pull/424/commits
The text was updated successfully, but these errors were encountered: