forked from adobe/brackets-shell
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for loading the icon list in Linux #452
Comments
Comment by radorodopski This should fix adobe/brackets#7141 |
Comment by nethip @radorodopski Did you get a chance to look at the suggested changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue by radorodopski
Friday Oct 24, 2014 at 22:31 GMT
Originally opened as adobe#483
This commit fixes a couple of things:
1. The list of icons was using relative paths.
2. If the icons could not be loaded, the error was ignored without a warning.
For 1) I am prefixing the icon paths with the directory where the Brackets executable resides (since the icons are there, too).
One might think that the paths are relative to the aforementioned directory, except that is only true if Brackets is started from the launcher. If I start Brackets from the command line (or if I specify another initial working dir), Brackets fails to load the icons.
On top of that, no warning is issued to the user, making this hard to trace as my window manager cached the icons (so for testing I had to rename the executable, too). Which leads me to 2), now I'm issuing a warning if Brackets fails to load any of the icons.
The bug was originally pointed out to me by another user - @orschiro on github.
Here's what it looks like:
To reproduce the issue:
Running the copy of the Brackets executable from 4) is necessary in order to bypass any cache the window manager might have.
radorodopski included the following code: https://github.com/adobe/brackets-shell/pull/483/commits
The text was updated successfully, but these errors were encountered: