refactor: dont use strings and uint64_t in dave, use snowflake type #1307

braindigitalis · 2024-10-22T17:15:45Z

Dave is a total snowflake now.

Code change checklist

I have ensured that all methods and functions are fully documented using doxygen style comments.
My code follows the coding style guide.
I tested that my change works before raising the PR.
I have ensured that I did not break any existing API calls.
I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

netlify · 2024-10-22T17:15:59Z

Name	Link
🔨 Latest commit	`02868c5`
🔍 Latest deploy log	https://app.netlify.com/sites/dpp-dev/deploys/6717ddc4b3afb80008f1d863
😎 Deploy Preview	https://deploy-preview-1307--dpp-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Neko-Life

👍🏻

braindigitalis added 2 commits October 22, 2024 16:59

refactor: dont use strings and uint64_t in dave, use snowflake type

c8781e8

refactor: change sets of strings to sets of snowflake

02868c5

braindigitalis self-assigned this Oct 22, 2024

braindigitalis requested review from Jaskowicz1 and Neko-Life and removed request for Jaskowicz1 October 22, 2024 17:15

github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 22, 2024

braindigitalis added audio audio issues or feature requests DAVE Issues or pull requests relating to DAVE E2EE labels Oct 22, 2024

Jaskowicz1 approved these changes Oct 22, 2024

View reviewed changes

Neko-Life approved these changes Oct 23, 2024

View reviewed changes

braindigitalis merged commit 83a86f6 into dev Oct 23, 2024
92 checks passed

braindigitalis deleted the dave-is-a-snowflake branch October 23, 2024 06:23