Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix various issues and bugs with dpp::emoji #775

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

Mishura4
Copy link
Member

@Mishura4 Mishura4 commented Aug 16, 2023

  • [✅] My pull request is made against the dev branch.
  • [❓ github actions will tell :kekw:] I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • [✅] I have ensured that all methods and functions are fully documented using doxygen style comments.
  • [✅] I tested my commits, by adding a test case to the unit tests if needed
  • [✅] I have ensured that I did not break any existing API calls.
  • [✅] My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • [✅] I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.
  • [✅] I agree to the terms of the DCO (Developer Certificate of Origin)

This PR fixes various bugs involving dpp::emoji, including a double free after copying an emoji with image data, as well as dpp::base64_encode reading past the end of the data sent to it. It also modernizes (a little bit) dpp::emoji, and adds utility functions to get a mime type and file extension from a dpp::image_type or a dpp::sticker_format.

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 78194dc
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/64dd333d32f51e0008820d10
😎 Deploy Preview https://deploy-preview-775--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

include/dpp/emoji.h Show resolved Hide resolved
include/dpp/emoji.h Show resolved Hide resolved
include/dpp/emoji.h Show resolved Hide resolved
@Mishura4 Mishura4 marked this pull request as draft August 16, 2023 19:54
@Mishura4 Mishura4 marked this pull request as ready for review August 16, 2023 20:39
@braindigitalis braindigitalis merged commit 0bc35a0 into brainboxdotcc:dev Aug 16, 2023
28 checks passed
@Mishura4 Mishura4 deleted the emoji_fix branch August 22, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants