Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added can and can_any methods to dpp::permission class #776

Merged
merged 13 commits into from
Aug 17, 2023

Conversation

Commandserver
Copy link
Member

@Commandserver Commandserver commented Aug 16, 2023

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.
  • I agree to the terms of the DCO (Developer Certificate of Origin)

The new methods do also return true, if the permission has the administrator flag set. Equal to the dpp::role methods

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 15f5efe
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/64dd60d4784439000812ba98
😎 Deploy Preview https://deploy-preview-776--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis braindigitalis merged commit 6cebf6f into brainboxdotcc:dev Aug 17, 2023
28 checks passed
@Commandserver Commandserver added the enhancement New feature or request label Aug 17, 2023
Commandserver added a commit to Commandserver/DPP that referenced this pull request Aug 17, 2023
feat: added can and can_any methods to dpp::permission class (brainboxdotcc#776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants