Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added docs page about checking permissions #777

Merged
merged 19 commits into from
Aug 20, 2023

Conversation

Commandserver
Copy link
Member

@Commandserver Commandserver commented Aug 17, 2023

This PR adds a new docs page about permissions and makes the glossar appear at the top of the "related pages".

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.
  • I agree to the terms of the DCO (Developer Certificate of Origin)

@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 78e25bd
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/64e1e7449644250008d5dd46
😎 Deploy Preview https://deploy-preview-777--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Commandserver Commandserver added the documentation Improvements or additions to documentation label Aug 17, 2023
@Commandserver
Copy link
Member Author

what do you think? does the new page fit more in "The basics", in "Misc Examples" or in "Advanced Reference"?

@Mishura4
Copy link
Member

I would put it in Interactions and Components tbh!
Though the basics could work

@Commandserver Commandserver marked this pull request as ready for review August 18, 2023 20:18
@Commandserver Commandserver marked this pull request as draft August 18, 2023 23:01
@Commandserver Commandserver marked this pull request as ready for review August 20, 2023 10:06
@Mishura4 Mishura4 merged commit c415bf5 into brainboxdotcc:dev Aug 20, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants