Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lib only allows one TCP connection at a time #11

Open
brainelectronics opened this issue Jul 16, 2022 · 4 comments
Open

Lib only allows one TCP connection at a time #11

brainelectronics opened this issue Jul 16, 2022 · 4 comments
Labels
bug Something isn't working host Host implementation specific issue

Comments

@brainelectronics
Copy link
Owner

As found out during #10 only one TCP Modbus connection can be established. If a second client connects to the master device, the first connection will be closed.

The parameter max_connections of the TCPServer class in function bind is misleading

see

self._sock.listen(max_connections)

@brainelectronics brainelectronics added the bug Something isn't working label Jul 16, 2022
@brainelectronics
Copy link
Owner Author

related to #18

@beyonlo
Copy link

beyonlo commented Jan 15, 2023

Hello @brainelectronics are you thinking to solve this bug as well?

@brainelectronics
Copy link
Owner Author

Good morning @beyonlo yes I'm planning to solve all of these issues. To be honest I have to rearrange prio a bit as I was exclusively working for this lib the last few weeks. Nevertheless I really try to get this bug as well as the strange CRC and Serial Control pin bug done. After that I'll quickly do the async milestone

@beyonlo
Copy link

beyonlo commented Jan 16, 2023

Hello @brainelectronics good morning :)

Good morning @beyonlo yes I'm planning to solve all of these issues.

That's great

To be honest I have to rearrange prio a bit as I was exclusively working for this lib the last few weeks.

I really realized that you was very very active in this project. You put this project in another level in the lasts weeks, in implementations and docs! Thank you so much for your effort!

Nevertheless I really try to get this bug as well as the strange CRC and Serial Control pin bug done.

Excellent!

After that I'll quickly do the async milestone

Amazing, this feature will be very useful! 🥳

GimmickNG added a commit to GimmickNG/pycopy-modbus that referenced this issue Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working host Host implementation specific issue
Projects
None yet
Development

No branches or pull requests

2 participants