Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload brainflow rust bindings to crates.io #721

Closed
Pandapip1 opened this issue May 9, 2024 · 7 comments
Closed

Upload brainflow rust bindings to crates.io #721

Pandapip1 opened this issue May 9, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@Pandapip1
Copy link

Use case:

I'd like to use brainflow in a rust project, and https://crates.io/ is the standard way of distributing Rust packages.

Describe the solution you'd like:

Brainflow should be uploaded to https://crates.io/

Describe alternatives you've considered:

N.A.

@Pandapip1 Pandapip1 added the enhancement New feature or request label May 9, 2024
@Andrey1994
Copy link
Member

hi, there is one problem I cannot solve with crates. BrainFlow uses C\C++ dyn libs in all bindings and crates does not allow to package binary files properly, there is a strict limitation for max size of the package.
idk how other projects bypass it

@Pandapip1
Copy link
Author

Pandapip1 commented May 9, 2024

hi, there is one problem I cannot solve with crates. BrainFlow uses C\C++ dyn libs in all bindings and crates does not allow to package binary files properly, there is a strict limitation for max size of the package.

My understanding is that crates just assume that the user has the libraries installed somewhere in their LD_LIBRARY_PATH.

@Andrey1994
Copy link
Member

but in that case users still need to download libraries from somewhere and set LD_LIBRARY_PATH or PATH manually. Then advantage of using crates only for Rust code is debatable

@Pandapip1
Copy link
Author

but in that case users still need to download libraries from somewhere and set LD_LIBRARY_PATH or PATH manually. Then advantage of using crates only for Rust code is debatable

Not really. When you use your distro's package manager, they set LD_LIBRARY_PATH for you. So all you need to do is install the brainflow C library, then the crate. And even if you do all of the C library stuff manually, uploading it to crates.io makes depending on specific versions of the bindings that much easier.

@retiutut
Copy link
Member

It does seem to be the official package distribution for Rust https://github.com/rust-lang/crates.io.

@Andrey1994 Andrey1994 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 28, 2024
@Pandapip1
Copy link
Author

Pandapip1 commented Dec 28, 2024

Was this closed accidentally, or is this actually not planned? If so, would you mind just providing a short explanation for the wontfix, since all your previous concerns seem to have been addressed?

@Andrey1994
Copy link
Member

Wont fix, I dont see much value uploading rust part only wo compiled libs, they still should be copied manually. And afik there is still file size limit.
So until there is no more or less acceptable way to bundle C libs with rust part we will not upload it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants