Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pooch to download data #284

Open
adamltyson opened this issue May 10, 2024 · 6 comments
Open

Use pooch to download data #284

adamltyson opened this issue May 10, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@adamltyson
Copy link
Member

Pooch could be used to download:

  • The atlases as part of the API
  • The data used to generate atlases

This would provide many benefits, mostly in that we could remove all of our own code to do this, and it would also provide validation that atlases are properly downloaded (with checksums etc).

@adamltyson
Copy link
Member Author

this should hopefully fix - #334

@PolarBean
Copy link
Contributor

I support using pooch to download the atlases in the atlas creation scripts, but one benefit of using a centralised database of atlases is we avoid link rot. So many atlasing papers I have been reviewing recently have dead links to the data files. In many cases these datasets are completely lost. Maybe this is out of scope for the API though.

@adamltyson
Copy link
Member Author

This issue is about using pooch to:

  • Fetch the atlas data during packaging
  • Fetch the data from GIN when using the API

It only replaces the ad-hoc approach of using different download functions. We will still store our own central copy of all (repackaged) atlases on GIN (and in the future, likely mirrored elsewhere).

@PolarBean
Copy link
Contributor

ah that makes sense then!

@NicoKiaru
Copy link

I don't know if it's really part of this issue, but why not storing the atlas raw data on Zenodo ? I experience a very slow download speed with brainglobe (less than a 1MB/s). Zenodo has a very good infrastructure and allow direct dl links without login, etc. And I have a dl speed of over 50 Mb/s over wifi, so wifi is probably limiting here.

@adamltyson
Copy link
Member Author

It's a different issue, but a good point. We're looking at setting up mirrors to improve download speed, but zenodo does seem like a good option. I'm not sure what happened with GIN, I don't recall it being this slow when we first set it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants