-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardise the use of axes in cellfinder #413
Comments
In my pytorch branch, which I'm getting ready to PR, I had to go through all the detection parts to get it working with torch. And I removed all the flips or any assumptions about the order of the last two axis and it worked fine. So at least for the detection code it may be fixed in that PR. I also started referring to these last two dimensions as dim1/dim2 for each plane, as it doesn't make any difference for the order as long as there's no flipping in the middle. But I can refer to them as height/width (in that order) if that's preferred. |
Fantastic!
If it's not too much trouble, could you call them axis 0, axis 1 etc. to match numpy? |
Currently most of cellfinder uses height/width, but this is often in the wrong order for numpy axis ordering. The third dimension (z) is also often last (rather than first).
It would be helpful long term to standardise everything, e.g. around numpy axis ordering.
Ref #411
The text was updated successfully, but these errors were encountered: