From 45f36f2f6f1b92457835988a14d04ec2a3762bfd Mon Sep 17 00:00:00 2001 From: pbalcer Date: Thu, 3 Aug 2023 13:03:41 +0200 Subject: [PATCH] [umf][disjoint pool] fix potential unchaught exception in USM Alloc Found by Coverity. --- source/common/umf_pools/disjoint_pool.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/source/common/umf_pools/disjoint_pool.cpp b/source/common/umf_pools/disjoint_pool.cpp index 7efd243f63..5c6c3a852a 100644 --- a/source/common/umf_pools/disjoint_pool.cpp +++ b/source/common/umf_pools/disjoint_pool.cpp @@ -966,10 +966,10 @@ DisjointPool::~DisjointPool() { size_t HighPeakSlabsInUse; if (impl->getParams().PoolTrace > 1) { auto name = impl->getParams().name; - impl->printStats(TitlePrinted, HighBucketSize, HighPeakSlabsInUse, - name.c_str()); - if (TitlePrinted) { - try { // cannot throw in destructor + try { // cannot throw in destructor + impl->printStats(TitlePrinted, HighBucketSize, HighPeakSlabsInUse, + name.c_str()); + if (TitlePrinted) { std::cout << "Current Pool Size " << impl->getParams().limits->TotalSize.load() << std::endl; @@ -978,8 +978,8 @@ DisjointPool::~DisjointPool() { << std::string(name.c_str() + 1) << ":" << HighBucketSize << "," << HighPeakSlabsInUse << ",64K" << std::endl; - } catch (...) { // ignore exceptions } + } catch (...) { // ignore exceptions } } }