From 882aabbada2a47e4d929c6ea14b1cdef719d33e5 Mon Sep 17 00:00:00 2001
From: Ian Krieger <48930920+IanKrieger@users.noreply.github.com>
Date: Tue, 14 Nov 2023 13:34:51 -0500
Subject: [PATCH] fix: use Ads verbiage over creative verbiage (#971)

* fix: use Ads verbiage over creative verbiage

* fix: add explicit redirect
---
 src/components/Creatives/CreativeList.tsx            | 2 +-
 src/components/Creatives/hooks/useSubmitCreative.tsx | 2 +-
 src/components/Drawer/MiniSideBar.tsx                | 4 ++--
 src/components/Navigation/Navbar.tsx                 | 2 +-
 src/user/User.tsx                                    | 4 +++-
 src/user/ads/InlineContentAd.tsx                     | 2 +-
 src/user/ads/NotificationAd.tsx                      | 2 +-
 7 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/src/components/Creatives/CreativeList.tsx b/src/components/Creatives/CreativeList.tsx
index 650c265f..198e0432 100644
--- a/src/components/Creatives/CreativeList.tsx
+++ b/src/components/Creatives/CreativeList.tsx
@@ -87,7 +87,7 @@ export function CreativeList() {
         />
       )}
       <CardContainer
-        header="Creatives"
+        header="Ads"
         sx={{
           flexGrow: 1,
           overflowX: "auto",
diff --git a/src/components/Creatives/hooks/useSubmitCreative.tsx b/src/components/Creatives/hooks/useSubmitCreative.tsx
index 61f403cf..04bcee13 100644
--- a/src/components/Creatives/hooks/useSubmitCreative.tsx
+++ b/src/components/Creatives/hooks/useSubmitCreative.tsx
@@ -17,7 +17,7 @@ export function useSubmitCreative(props: { id: string }) {
   const refetchQueries = [
     refetchAdvertiserCreativesQuery({ advertiserId: advertiser.id }),
   ];
-  const onCompleted = () => history.replace("/user/main/creatives");
+  const onCompleted = () => history.replace("/user/main/ads");
 
   const [createCreative, { error: createError, loading: createLoading }] =
     useCreateCreativeMutation({
diff --git a/src/components/Drawer/MiniSideBar.tsx b/src/components/Drawer/MiniSideBar.tsx
index f6deb44e..f3dbfc19 100644
--- a/src/components/Drawer/MiniSideBar.tsx
+++ b/src/components/Drawer/MiniSideBar.tsx
@@ -57,8 +57,8 @@ export default function MiniSideBar({ children }: PropsWithChildren) {
       disabled: !advertiser.selfServiceManageCampaign,
     },
     {
-      label: "Creatives",
-      href: "/user/main/creatives",
+      label: "Ads",
+      href: "/user/main/ads",
       icon: (
         <LightbulbOutlinedIcon
           fontSize="large"
diff --git a/src/components/Navigation/Navbar.tsx b/src/components/Navigation/Navbar.tsx
index 150e358b..600ddb08 100644
--- a/src/components/Navigation/Navbar.tsx
+++ b/src/components/Navigation/Navbar.tsx
@@ -24,7 +24,7 @@ export function Navbar() {
       component: <UploadImage />,
     },
     {
-      route: "user/main/creatives",
+      route: "user/main/ads",
       component: <NewCreativeButton />,
     },
   ];
diff --git a/src/user/User.tsx b/src/user/User.tsx
index 38bf05c2..e76f3258 100644
--- a/src/user/User.tsx
+++ b/src/user/User.tsx
@@ -114,10 +114,12 @@ export function User() {
               />
 
               <ProtectedRoute
-                path="/user/main/creatives"
+                path="/user/main/ads"
                 authedComponent={CreativeList}
               />
 
+              <Redirect from="/user/main/creatives" to="/user/main/ads" exact />
+
               {/* default */}
               <Redirect to="/user/main/campaign" />
             </Switch>
diff --git a/src/user/ads/InlineContentAd.tsx b/src/user/ads/InlineContentAd.tsx
index f5ba3938..418daf50 100644
--- a/src/user/ads/InlineContentAd.tsx
+++ b/src/user/ads/InlineContentAd.tsx
@@ -26,7 +26,7 @@ export function InlineContentAd(props: {
 
   return (
     <Box display="flex" flexDirection="column" gap={2}>
-      <CardContainer header="News display creative" sx={{ flexGrow: 1 }}>
+      <CardContainer header="News Display Ad" sx={{ flexGrow: 1 }}>
         <FormikTextField name={withName("name")} label="Name" />
 
         <FormikTextField
diff --git a/src/user/ads/NotificationAd.tsx b/src/user/ads/NotificationAd.tsx
index c530ef8d..07bb7578 100644
--- a/src/user/ads/NotificationAd.tsx
+++ b/src/user/ads/NotificationAd.tsx
@@ -19,7 +19,7 @@ export function NotificationAd(props: {
   }, []);
 
   return (
-    <CardContainer header="Notification creative">
+    <CardContainer header="Notification Ad">
       <FormikTextField name={withName("name")} label="Name" />
 
       <Stack direction="row" alignItems="center" spacing={1}>