Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permit submission of creatives that fail validation #1203

Open
tackley opened this issue May 24, 2024 · 1 comment
Open

permit submission of creatives that fail validation #1203

tackley opened this issue May 24, 2024 · 1 comment
Assignees

Comments

@tackley
Copy link
Collaborator

tackley commented May 24, 2024

Currently, some self-serve advertisers may experience a 403 error or unexpected failures when validating their URLs due to DDoS protection or technical errors. This issue prevents the campaign from progressing beyond the creative setup stage, and may result in the loss of the advertiser.

Proposed Solution:
If URL validation fails with a 403 error or unexpected failure, the submission will still pass checks and advance to the ad ops review queue. Ad ops will manually review and validate the URL to ensure the creatives do not include any redirects, and the failures are false failures.

Originally posted by @StephenBass in https://github.com/brave/ads-serve/discussions/3945

@diracdeltas
Copy link
Member

Ideally this would just be solved by making the validation service more robust. If it has to fall back to a human check, someone needs to make sure the human process is updated whenever the automated checks are updated.

@tackley tackley self-assigned this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants