From 23a7efe733b56da8ab5b12693786346d1850ff93 Mon Sep 17 00:00:00 2001 From: Ian Krieger <48930920+IanKrieger@users.noreply.github.com> Date: Thu, 21 Sep 2023 12:58:49 -0400 Subject: [PATCH 1/2] fix: update perDay & totalMax defaults (#893) * fix: update perDay & totalMax defaults * fix: tests --- src/user/library/index.test.ts | 4 ++-- src/user/library/index.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/user/library/index.test.ts b/src/user/library/index.test.ts index 3aca2f99..4c468ba4 100644 --- a/src/user/library/index.test.ts +++ b/src/user/library/index.test.ts @@ -283,14 +283,14 @@ describe("new form tests", () => { "name": "macos", }, ], - "perDay": 1, + "perDay": 4, "segments": [ { "code": "5678", "name": "test", }, ], - "totalMax": 10, + "totalMax": 28, }, ], "advertiserId": "12345", diff --git a/src/user/library/index.ts b/src/user/library/index.ts index 3d13df89..4543e1de 100644 --- a/src/user/library/index.ts +++ b/src/user/library/index.ts @@ -53,10 +53,10 @@ export function transformNewForm( adSets: form.adSets.map((adSet) => ({ name: adSet.name, billingType: form.billingType, - perDay: 1, + perDay: form.format === CampaignFormat.PushNotification ? 4 : 6, segments: adSet.segments.map((s) => ({ code: s.code, name: s.name })), oses: adSet.oses, - totalMax: 10, + totalMax: form.format === CampaignFormat.PushNotification ? 28 : 60, conversions: transformConversion(adSet.conversions), ads: adSet.creatives .filter((c) => c.included) From de5bbc800819855b1cfc6921f44141a1d7a346c3 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 21 Sep 2023 15:03:38 -0400 Subject: [PATCH 2/2] fix(deps): update dependency graphql to v16.8.1 [security] (#896) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --- package-lock.json | 26 +++++++++++++------------- package.json | 2 +- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/package-lock.json b/package-lock.json index 83f01130..c7b5f5aa 100644 --- a/package-lock.json +++ b/package-lock.json @@ -24,7 +24,7 @@ "date-fns": "2.30.0", "date-fns-tz": "2.0.0", "formik": "2.4.4", - "graphql": "16.8.0", + "graphql": "16.8.1", "highcharts": "11.1.0", "highcharts-react-official": "3.2.1", "immer": "10.0.2", @@ -1870,9 +1870,9 @@ } }, "node_modules/@eslint/eslintrc/node_modules/globals": { - "version": "13.21.0", - "resolved": "https://registry.npmjs.org/globals/-/globals-13.21.0.tgz", - "integrity": "sha512-ybyme3s4yy/t/3s35bewwXKOf7cvzfreG2lH0lZl0JB7I4GxRP2ghxOK/Nb9EkRXdbBXZLfq/p/0W2JUONB/Gg==", + "version": "13.22.0", + "resolved": "https://registry.npmjs.org/globals/-/globals-13.22.0.tgz", + "integrity": "sha512-H1Ddc/PbZHTDVJSnj8kWptIRSD6AM3pK+mKytuIVF4uoBV7rshFlhhvA58ceJ5wp3Er58w6zj7bykMpYXt3ETw==", "dev": true, "dependencies": { "type-fest": "^0.20.2" @@ -5834,9 +5834,9 @@ } }, "node_modules/eslint/node_modules/globals": { - "version": "13.21.0", - "resolved": "https://registry.npmjs.org/globals/-/globals-13.21.0.tgz", - "integrity": "sha512-ybyme3s4yy/t/3s35bewwXKOf7cvzfreG2lH0lZl0JB7I4GxRP2ghxOK/Nb9EkRXdbBXZLfq/p/0W2JUONB/Gg==", + "version": "13.22.0", + "resolved": "https://registry.npmjs.org/globals/-/globals-13.22.0.tgz", + "integrity": "sha512-H1Ddc/PbZHTDVJSnj8kWptIRSD6AM3pK+mKytuIVF4uoBV7rshFlhhvA58ceJ5wp3Er58w6zj7bykMpYXt3ETw==", "dev": true, "dependencies": { "type-fest": "^0.20.2" @@ -6431,9 +6431,9 @@ "dev": true }, "node_modules/graphql": { - "version": "16.8.0", - "resolved": "https://registry.npmjs.org/graphql/-/graphql-16.8.0.tgz", - "integrity": "sha512-0oKGaR+y3qcS5mCu1vb7KG+a89vjn06C7Ihq/dDl3jA+A8B3TKomvi3CiEcVLJQGalbu8F52LxkOym7U5sSfbg==", + "version": "16.8.1", + "resolved": "https://registry.npmjs.org/graphql/-/graphql-16.8.1.tgz", + "integrity": "sha512-59LZHPdGZVh695Ud9lRzPBVTtlX9ZCV150Er2W43ro37wVof0ctenSaskPPjN7lVTIN8mSZt8PHUNKZuNQUuxw==", "engines": { "node": "^12.22.0 || ^14.16.0 || ^16.0.0 || >=17.0.0" } @@ -9142,9 +9142,9 @@ "peer": true }, "node_modules/resolve": { - "version": "1.22.4", - "resolved": "https://registry.npmjs.org/resolve/-/resolve-1.22.4.tgz", - "integrity": "sha512-PXNdCiPqDqeUou+w1C2eTQbNfxKSuMxqTCuvlmmMsk1NWHL5fRrhY6Pl0qEYYc6+QqGClco1Qj8XnjPego4wfg==", + "version": "1.22.6", + "resolved": "https://registry.npmjs.org/resolve/-/resolve-1.22.6.tgz", + "integrity": "sha512-njhxM7mV12JfufShqGy3Rz8j11RPdLy4xi15UurGJeoHLfJpVXKdh3ueuOqbYUcDZnffr6X739JBo5LzyahEsw==", "dependencies": { "is-core-module": "^2.13.0", "path-parse": "^1.0.7", diff --git a/package.json b/package.json index b356e060..42c7d75e 100644 --- a/package.json +++ b/package.json @@ -19,7 +19,7 @@ "date-fns": "2.30.0", "date-fns-tz": "2.0.0", "formik": "2.4.4", - "graphql": "16.8.0", + "graphql": "16.8.1", "highcharts": "11.1.0", "highcharts-react-official": "3.2.1", "immer": "10.0.2",