Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IPFS Kubo to 0.19.1 #29556

Closed
lidel opened this issue Apr 6, 2023 · 0 comments · Fixed by brave/brave-core-crx-packager#608
Closed

Update IPFS Kubo to 0.19.1 #29556

lidel opened this issue Apr 6, 2023 · 0 comments · Fixed by brave/brave-core-crx-packager#608

Comments

@lidel
Copy link

lidel commented Apr 6, 2023

cc @cypt4 @bbondy @autonome

Signed Binaries: https://dist.ipfs.tech/kubo/v0.19.1/
Release Notes: https://github.com/ipfs/kubo/blob/master/docs/changelogs/v0.19.md

Some bugfixes, but there should be no impact on features exposed by Brave.

Something to consider: switch routing from auto to autoclient

0.19 adds autoclient routing mode, which will never run DHT Server, only DHT Client.

This mode aims to reduce CPU/bandwidth cost for laptop users, when user's node is publicly diallable (e.g. due to UPnP being available on the network): the implicit default auto mode will run DHT Server (if possible), autoclient won't.

Details:

Should Brave do this? Depends. Did your users complain about IPFS node consuming CPU/Bandwidth since 0.18 update (#27965)?
If so, switching to autoclient may improve the situation.
If not, leave things as-is (auto is good enough).

How to force autoclient without hardcoding it in the config?

ipfa daemon supports --routing=autoclient CLI override, so Brave could add one line to from ipfs_service_impl.cc:

  args.AppendArg("daemon");
  args.AppendArg("--migrate=true");
  args.AppendArg("--enable-gc");
+ args.AppendArg("--routing=autoclient");

This will switch to Routing.Type to autoclient without touching user's config (allowing Brave to adjust this in the future).

cypt4 added a commit to brave/brave-core-crx-packager that referenced this issue Apr 12, 2023
cypt4 added a commit to brave/brave-core-crx-packager that referenced this issue Apr 12, 2023
@yrliou yrliou added this to Web3 Apr 19, 2023
@yrliou yrliou moved this to In Review in Web3 Apr 19, 2023
@srirambv srirambv added this to the [IPFS] Kubo 0.19.1 Release milestone Apr 20, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants