Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra UMA and traces to adblock loading code #33532

Closed
atuchin-m opened this issue Oct 10, 2023 · 1 comment · Fixed by brave/brave-core#20585
Closed

Add extra UMA and traces to adblock loading code #33532

atuchin-m opened this issue Oct 10, 2023 · 1 comment · Fixed by brave/brave-core#20585
Assignees
@atuchin-m
Labels
dev-concern feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop perf QA/No release-notes/exclude
Milestone
1.59.x - Release #4

Comments

@atuchin-m
Copy link
Contributor

To debug and prevent perf issues we need to add extra instrumentation to loading & parsing adblock code.
@atuchin-m atuchin-m added feature/shields/adblock Blocking ads & trackers with Shields QA/No perf dev-concern release-notes/exclude OS/Android Fixes related to Android browser functionality OS/Desktop labels Oct 10, 2023
@atuchin-m atuchin-m self-assigned this Oct 10, 2023
@atuchin-m atuchin-m mentioned this issue Oct 10, 2023
Closed
25 tasks
@atuchin-m atuchin-m mentioned this issue Oct 18, 2023
Merged
25 tasks
@atuchin-m
Copy link
Contributor Author

How to debug see the new traces:

  1. Run browser with --trace-startup="brave.adblock" --trace-startup-file=/tmp/trace.json --trace-startup-duration=10
  2. Go to https://ui.perfetto.dev/ and open /tmp/trace.json
  3. Search for the events.

An example of verifying brave/brave-core#20585:
Search for MakeEngineWithRules, check the durations. We could see that we don't parse the default list again.
Screenshot 2023-10-18 at 19 08 30

@atuchin-m atuchin-m mentioned this issue Oct 18, 2023
Open
@brave-builds brave-builds added this to the 1.61.x - Nightly milestone Oct 18, 2023
This was referenced Oct 19, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atuchin-m atuchin-m

Labels
dev-concern feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop perf QA/No release-notes/exclude
Projects
None yet
Milestone
1.59.x - Release #4
2 participants
@brave-builds @atuchin-m