Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SequentialUpdateChecker in favor of upstream implementation if possible #37933

Open
goodov opened this issue Apr 29, 2024 · 0 comments
Open

Comments

@goodov
Copy link
Member

goodov commented Apr 29, 2024

Look into batching component update checks into a single update request. Upstream support this, but we disable this logic, because:

// Google's ToS do not allow distributing all components. In particular, the
// Widevine plugin must be fetched from Google servers. Brave's update server
// for components handles this as follows: When an update for a Google
// component is requested, the server responds with a HTTP redirect to
// Google's server. The problem is that this only works for update requests
// for single components. But Chromium's default implementation sends a list of
// components in one request, which in Brave's case is a mix of Google and Brave
// components. To solve this, we overwrite Chromium's implementation to perform
// separate update requests instead.

If there's no reasons that block us from batching the update request (fingerprinting, legal, performance, costs), then we can update go-updater to support Brave/non-Brave components in a single request and make it proxy requests to the upstream updater automatically.

See the discussion in brave/brave-core#23169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant