Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Ad and Tracker Blocking is Set to Aggressive Custom Blocking Rules Don't Work #40162

Closed
2 of 6 tasks
DanielProg39 opened this issue Jul 31, 2024 · 2 comments
Closed
2 of 6 tasks
Assignees
Labels
feature/shields/adblock Blocking ads & trackers with Shields needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Desktop

Comments

@DanielProg39
Copy link

Description

When ad and tracker blocking is set to aggressive, custom blocking rules generally don't work, and refreshing pages for which custom blocking rules have been set will sometimes block content and sometimes not. If ad and tracker blocking is set to standard, custom blocking works.

Steps to reproduce

  1. Block an element on a webpage
  2. Set ad and tracker blocking to aggressive
  3. Refresh the page several times
  4. Set ad and tracker blocking to standard
  5. Refresh the page several times

Actual result

When ad and tracker blocking is set to aggressive, sometimes the element is blocked and sometimes not. If ad and tracker blocking is set to standard, custom blocking works properly.

Expected result

When ad and tracker blocking is on, custom rules should work every time the page is opened.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave: 1.68.128 Chromium: 127.0.6533.73 (Official build) (64 bit)
Revision: 800676fd9ede2eb4174bac98c186e53749c7201f
OS: Linux

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

Also noticed that cosmetic filtering may have become worse when filtering is set to aggressive.

@antonok-edm
Copy link
Collaborator

antonok-edm commented Jul 31, 2024

@DanielProg39 we've just pushed out a change that might help - can you visit brave://components, update Brave Ad Block Updater to version 1.0.7178 or later, and let me know if that fixed it?

(probably related to #40151)

@antonok-edm antonok-edm added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Jul 31, 2024
@antonok-edm antonok-edm self-assigned this Jul 31, 2024
@antonok-edm antonok-edm added the feature/shields/adblock Blocking ads & trackers with Shields label Jul 31, 2024
@DanielProg39
Copy link
Author

Yes, that seems to have fixed it. Set blocking to aggressive and everything is blocked properly.

Unrelated: could you look at #32533? I opened it a while ago, and many Brave versions later, it is still unresolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/adblock Blocking ads & trackers with Shields needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Desktop
Projects
None yet
Development

No branches or pull requests

2 participants