Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for new Twitch adblocking list #41053

Closed
ShivanKaul opened this issue Sep 13, 2024 · 1 comment
Closed

Support for new Twitch adblocking list #41053

ShivanKaul opened this issue Sep 13, 2024 · 1 comment
Assignees
@ShivanKaul
Labels
closed/duplicate Issue has already been reported dev-concern feature/shields/adblock Blocking ads & trackers with Shields feature-request priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@ShivanKaul
Copy link
Collaborator

Platforms

all

Description

We'll want to turn it on by default on Nightly and Beta (initially) via Griffin.

Also see the following:

  1. List catalog PR
  2. Adblock list
@ShivanKaul ShivanKaul added feature/shields/adblock Blocking ads & trackers with Shields priority/P3 The next thing for us to work on. It'll ride the trains. QA/No dev-concern release-notes/exclude feature-request labels Sep 13, 2024
@ShivanKaul ShivanKaul self-assigned this Sep 13, 2024
@ShivanKaul ShivanKaul mentioned this issue Sep 13, 2024
Closed
24 tasks
@ShivanKaul
Copy link
Collaborator Author

It would be simplest to just roll this out via filterlist catalog: brave/adblock-resources#214

@ShivanKaul ShivanKaul closed this as not planned Won't fix, can't repro, duplicate, stale Sep 17, 2024
@ShivanKaul ShivanKaul added the closed/duplicate Issue has already been reported label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShivanKaul ShivanKaul

Labels
closed/duplicate Issue has already been reported dev-concern feature/shields/adblock Blocking ads & trackers with Shields feature-request priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for enabling Twitch adblocking list by default brave/brave-core
1 participant
@ShivanKaul