You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure if it's actually wise to provide a default epsilon/tolerance - this is the very problem that Bruce Dawson discusses in the randomascii blog I know we've both spent some time reading. The problem with absolute differences is that there is really no sensible default - it depends entirely on the numbers you are comparing.
The text was updated successfully, but these errors were encountered:
Note that I was referring explicitly to the absolute difference test for equality in that code, by the way. A default tolerance makes more sense for relative/ulp-based comparison.
Which epsilon do you mean, exactly? The absolute difference for comparing near-zero numbers that Bruce Dawson advocates in his blog, or the tolerance used for comparison with relative error or ULPs respectively?
IIRC, I think the defaults you've already been using in this crate have been fairly sane.
As @Andlon explains:
The text was updated successfully, but these errors were encountered: