Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QOL] Skipping 0 number cases #17

Open
brianleect opened this issue Mar 26, 2023 · 1 comment
Open

[QOL] Skipping 0 number cases #17

brianleect opened this issue Mar 26, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brianleect
Copy link
Owner

Currently time is often wasted looping through on cases where there are 0 accounts or tokens.

E.g. augmented-finance has 0 tokens but for every scraping run it attempts to check it still

Ideally rather than hitting the page and finding out, we should have a step at labelcloud scraping stage which determines the number of labels and if tokens/account even exists for that label.

@brianleect brianleect added enhancement New feature or request good first issue Good for newcomers labels Mar 26, 2023
@brianleect
Copy link
Owner Author

Similar scraping procedure needed for #15 but in this case we simply check for the existence of the segment account or token rather than require a specific number

brianleect added a commit that referenced this issue Mar 26, 2023
attempts to fix #15 and #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant