Removing skip_push
parameter for IngestJob.push_remote_and_launch_ingest
(SCP-4576)
#1591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACKGROUND & CHANGES
The Ruby 3.1 update exposed a regression with passing parameters to methods when invoking them via
delay
. This is only used inIngestJob.push_remote_and_launch_ingest
where we pass theskip_push
parameter, which will skip attempting to push a file to a bucket if it is already there. However, inspection of the code revealed that this would never actually be exercised as we check first to see if the file has in fact been pushed to the bucket. Therefore, this update removes the parameter from the method definition.It is unclear whyUPDATE: It appears this is a known issue indelay
is not passing parameters properly - we are on the latest release ofDelayedJob
. It is likely related to the Ruby 3.1 update and the hash/literal shorthand updates. We may need to open a support ticket withDelayedJob
if we ever need to use this feature.DelayedJob
and methods with keyword arguments. Thankfully, we do not require them at this time, but if we do ever need to support kwargs viadelay
, we will need this bug fixed. There appear to be several open PRs aimed at adding better support for Ruby 3.1, so hopefully this will be fixed soon.This also updates
sentry-raven
to a more recent release to silence themultipart-post
deprecation warnings in the logs.MANUAL TESTING
DelayedJob
with./rails_local_setup.rb && source config/secrets/.source_env.bash && bin/rails jobs:work
development.log
, validate the job launched by looking for the PAPI parameters: