Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"č" character doesn't work in hints #2115

Open
svenko99 opened this issue May 16, 2024 · 1 comment
Open

"č" character doesn't work in hints #2115

svenko99 opened this issue May 16, 2024 · 1 comment

Comments

@svenko99
Copy link

svenko99 commented May 16, 2024

Error details

Having a character "č" (api.Hints.setCharacters('asdfghjklčweruiocm');) shows in hints to open a link, but when I press the combination where "č" is present, the link doesn't open.

SurfingKeys: 1.15.0

Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.4.1 Safari/605.1.15

URL: Every URL

Context

Normal usage

@Fred-Vatin
Copy link

Fred-Vatin commented Oct 24, 2024

I confirm this.

setup

  • Firefox 131.0.3, SK 1.16.1
  • Vivaldi 6.9.3447.54, SK 1.17.3
  • OS Win 10 pro 22H2

issue

I have a US ansi keyboard. But I use a layout that send é when pressing KeyK
image

Using

Hints.setCharacters("fdsjél");

will show É in hints but pressing KeyK won’t activate it as expected.

I have to use this settings to actually use KeyK:

Hints.setCharacters("fdsjkl");

But the hints will show K instead of É.

Conclusion

In other words, hints must be set using event.code instead of event.key. Why not if it is documented. It makes the keys consistant throughout different layouts. But there should be a setting to chose between using event.key or event.code to display characters in hints.

Vimium C has this settings
image


Related issue with the functions forward/backward to next char in visual mode. To jump to a char, it seems it reads event.code instead of event.key. Because of that, I can not jump to é in a word by pressing k on my layout because it would jump to k.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants