-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore the write with proposedValue === undefined
#11
Comments
Another implication: default values are ignored. Scheduling engine passes quite a few |
proposedValue === undefined
Currently by design, for the scenario:
User expectation is probably that Need more feedback to proceed with such change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feels wrong to merge
null
andundefined
values.undefined
is smth that doesn't exist,null
on the other hand is smth that exists, but doesn't have value.This makes
write(identifier, undefined)
same aswrite(identifier, null)
. Latter is definitely user wanting to null the value. First doesn't make sense to call deliberately, rather a handy filter for undefined values - if undefined is passed then do nothing.chronograph/src/chrono/Transaction.ts
Line 455 in 0db8d13
The text was updated successfully, but these errors were encountered: