Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php 8 and pull requests #12

Open
joelfan opened this issue Mar 11, 2022 · 3 comments
Open

Php 8 and pull requests #12

joelfan opened this issue Mar 11, 2022 · 3 comments

Comments

@joelfan
Copy link

joelfan commented Mar 11, 2022

Dear Sam,

I understand that bsobbe/iThenticate requires php7 but excludes php8. It seems to me that the issue is due to the use of phpxmlrpc 4.0. In fact, compose.json states "phpxmlrpc/phpxmlrpc": "4.0". I know that phpxmlrpc/phpxmlrpc is now updated to 4.6.1. As far as I know, php8 is not compatible with some php7 instructions (for example "each" operator), hence bsobbe/iThenticate is not compatible with php8. Have you got plans to port it to php8?

Secondarily, it would be super if bsobbe/iThenticate library could also include iThenticate user management. That means define a new user if not existing and share a folder to other users when necessary. We would like to know your view about it.

Thx a lot for you help.

@bsobbe
Copy link
Owner

bsobbe commented Mar 21, 2022

@joelfan Sorry for the late response. I have no plans for this repository anytime soon, but it would be nice to have that support. you could fork and do a PR so everybody else could benefit from this support as well :)

@joelfan
Copy link
Author

joelfan commented Mar 22, 2022

Ok.
I will fork and then come back.

@joelfan
Copy link
Author

joelfan commented Mar 22, 2022

Dear Sam, I've done the fork and the pull.
I also tested it.
Please take a look and tell me your view.

Repository owner deleted a comment from katsavav Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants