-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Php 8 and pull requests #12
Labels
Comments
@joelfan Sorry for the late response. I have no plans for this repository anytime soon, but it would be nice to have that support. you could fork and do a PR so everybody else could benefit from this support as well :) |
Ok. |
Dear Sam, I've done the fork and the pull. |
Repository owner
deleted a comment from
katsavav
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Dear Sam,
I understand that bsobbe/iThenticate requires php7 but excludes php8. It seems to me that the issue is due to the use of phpxmlrpc 4.0. In fact, compose.json states "phpxmlrpc/phpxmlrpc": "4.0". I know that phpxmlrpc/phpxmlrpc is now updated to 4.6.1. As far as I know, php8 is not compatible with some php7 instructions (for example "each" operator), hence bsobbe/iThenticate is not compatible with php8. Have you got plans to port it to php8?
Secondarily, it would be super if bsobbe/iThenticate library could also include iThenticate user management. That means define a new user if not existing and share a folder to other users when necessary. We would like to know your view about it.
Thx a lot for you help.
The text was updated successfully, but these errors were encountered: