Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gnag comments with incorrect PR SHA if 1+ new commits were added between build starting and Gnag reporting #114

Open
stkent opened this issue Jul 5, 2016 · 0 comments
Open

Gnag comments with incorrect PR SHA if 1+ new commits were added between build starting and Gnag reporting #114

stkent opened this issue Jul 5, 2016 · 0 comments
Labels
bug code difficulty-medium question

Comments

@stkent
Copy link
Collaborator

stkent commented Jul 5, 2016 •
edited
Loading

screen shot 2016-07-05 at 10 36 15 am

Expected: comments reported as applying to SHAs 3623c3b then 005ef31.
Actual: comments reported as applying to SHA 005ef31 both times.

An improved solution would be to pull the PR HEAD SHA ASAP in the Gnag build. May also be possible to capture a CI env var with this information (which would be much more robust). Maybe we add a new entry in the Gnag configuration block to allow this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug code difficulty-medium question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stkent