Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding taxonomy type in facetted results #103

Closed
eroux opened this issue Oct 12, 2018 · 5 comments
Closed

adding taxonomy type in facetted results #103

eroux opened this issue Oct 12, 2018 · 5 comments

Comments

@eroux
Copy link
Contributor

eroux commented Oct 12, 2018

Some hits returned by the root search query are of type :Taxonomy but currently break the code. I've patched it so that it doesnt break, but these results should be handled properly (see here)
@eroux
Copy link
Contributor Author

eroux commented Oct 12, 2018

(same with etexts that have labels that could be returned)

This was referenced Oct 12, 2018
Closed
Closed
@MarcAgate
Copy link
Collaborator

This is addressed in commit 9b3f960 . However, in root search results, only the count of etexts having a chunk containing the requested string is returned (Etexts_count.arq). A second call (in the facet panel) actually serves the etexts details.

@MarcAgate
Copy link
Collaborator

The actual commit is fafa9c4
See http://purl.bdrc.io/lib/rootSearchGraph?LG_NAME=bo-x-ewts&I_LIM=500&L_NAME=%22bka%27%20bstan%22

@MarcAgate
Copy link
Collaborator

This should be closed as well. WDYT ?

@eroux
Copy link
Contributor Author

eroux commented Jul 29, 2019

I think so, I actually think it's more an issue in the data: buda-base/git-to-dbs#15 so let's close it here yes

@eroux eroux closed this as completed Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eroux @MarcAgate