diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml index bf2f0b7b1..62537e7fc 100644 --- a/.buildkite/pipeline.yml +++ b/.buildkite/pipeline.yml @@ -93,7 +93,7 @@ steps: agents: queue: opensource-mac-cocoa-10.13 commands: - - ./scripts/run-unit-tests.sh PLATFORM=iOS OS=9.3 DEVICE=iPhone\ 5s XCODEBUILD_EXTRA_ARGS=-skip-testing:BugsnagNetworkRequestPlugin-iOSTests + - ./scripts/run-unit-tests.sh PLATFORM=iOS OS=9.0 DEVICE=iPhone\ 5s XCODEBUILD_EXTRA_ARGS=-skip-testing:BugsnagNetworkRequestPlugin-iOSTests artifact_paths: - logs/* diff --git a/.jazzy.yaml b/.jazzy.yaml index 27b4672af..32c45559d 100644 --- a/.jazzy.yaml +++ b/.jazzy.yaml @@ -2,11 +2,11 @@ author_url: "https://www.bugsnag.com" author: "Bugsnag Inc" clean: false # avoid deleting docs/.git framework_root: "Bugsnag" -github_file_prefix: "https://github.com/bugsnag/bugsnag-cocoa/tree/v6.16.7/Bugsnag" +github_file_prefix: "https://github.com/bugsnag/bugsnag-cocoa/tree/v6.16.8/Bugsnag" github_url: "https://github.com/bugsnag/bugsnag-cocoa" hide_documentation_coverage: true module: "Bugsnag" -module_version: "6.16.7" +module_version: "6.16.8" objc: true output: "docs" readme: "README.md" diff --git a/BUGSNAG-PLUGIN.md b/BUGSNAG-PLUGIN.md index b6b7c8449..3c42b2e5e 100644 --- a/BUGSNAG-PLUGIN.md +++ b/BUGSNAG-PLUGIN.md @@ -146,7 +146,7 @@ Create a `BugsnagXYZ.podspec.json` file similar to the existing `Bugsnag.podspec "Bugsnag": "6.11.0" }, "platforms": { - "ios": "9.3", + "ios": "9.0", "osx": "10.11", "tvos": "9.2" }, diff --git a/Bugsnag.podspec.json b/Bugsnag.podspec.json index a2ab3e37d..1b9682ac6 100644 --- a/Bugsnag.podspec.json +++ b/Bugsnag.podspec.json @@ -1,6 +1,6 @@ { "name": "Bugsnag", - "version": "6.16.7", + "version": "6.16.8", "summary": "The Bugsnag crash reporting framework for Apple platforms.", "homepage": "https://bugsnag.com", "license": "MIT", @@ -9,7 +9,7 @@ }, "source": { "git": "https://github.com/bugsnag/bugsnag-cocoa.git", - "tag": "v6.16.7" + "tag": "v6.16.8" }, "frameworks": [ "Foundation", @@ -20,7 +20,7 @@ "c++", "z" ], "platforms": { - "ios": "9.3", + "ios": "9.0", "osx": "10.11", "tvos": "9.2" }, diff --git a/Bugsnag.xcodeproj/project.pbxproj b/Bugsnag.xcodeproj/project.pbxproj index 6295c2c3d..9cfdbc2f5 100644 --- a/Bugsnag.xcodeproj/project.pbxproj +++ b/Bugsnag.xcodeproj/project.pbxproj @@ -3343,7 +3343,7 @@ "$(inherited)", ); INFOPLIST_FILE = ./Framework/Info.plist; - IPHONEOS_DEPLOYMENT_TARGET = 9.3; + IPHONEOS_DEPLOYMENT_TARGET = 9.0; MACOSX_DEPLOYMENT_TARGET = 10.11; MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE; MTL_FAST_MATH = YES; @@ -3384,7 +3384,7 @@ GCC_C_LANGUAGE_STANDARD = gnu11; GCC_NO_COMMON_BLOCKS = YES; INFOPLIST_FILE = ./Framework/Info.plist; - IPHONEOS_DEPLOYMENT_TARGET = 9.3; + IPHONEOS_DEPLOYMENT_TARGET = 9.0; MACOSX_DEPLOYMENT_TARGET = 10.11; MTL_ENABLE_DEBUG_INFO = NO; MTL_FAST_MATH = YES; @@ -3661,7 +3661,6 @@ baseConfigurationReference = 017824BD262D65A000D18AFA /* Bugsnag.xcconfig */; buildSettings = { CODE_SIGN_STYLE = Automatic; - IPHONEOS_DEPLOYMENT_TARGET = 9.3; PRODUCT_NAME = "$(TARGET_NAME)"; SKIP_INSTALL = YES; TARGETED_DEVICE_FAMILY = "1,2"; @@ -3673,7 +3672,6 @@ baseConfigurationReference = 017824BD262D65A000D18AFA /* Bugsnag.xcconfig */; buildSettings = { CODE_SIGN_STYLE = Automatic; - IPHONEOS_DEPLOYMENT_TARGET = 9.3; PRODUCT_NAME = "$(TARGET_NAME)"; SKIP_INSTALL = YES; TARGETED_DEVICE_FAMILY = "1,2"; diff --git a/Bugsnag/Payload/BugsnagNotifier.m b/Bugsnag/Payload/BugsnagNotifier.m index d01458b77..512038900 100644 --- a/Bugsnag/Payload/BugsnagNotifier.m +++ b/Bugsnag/Payload/BugsnagNotifier.m @@ -21,7 +21,7 @@ - (instancetype)init { #else _name = @"Bugsnag Objective-C"; #endif - _version = @"6.16.7"; + _version = @"6.16.8"; _url = @"https://github.com/bugsnag/bugsnag-cocoa"; _dependencies = @[]; } diff --git a/BugsnagNetworkRequestPlugin.podspec.json b/BugsnagNetworkRequestPlugin.podspec.json index 209a5742e..78d4679e5 100644 --- a/BugsnagNetworkRequestPlugin.podspec.json +++ b/BugsnagNetworkRequestPlugin.podspec.json @@ -1,22 +1,22 @@ { "name": "BugsnagNetworkRequestPlugin", - "version": "6.16.7", + "version": "6.16.8", "summary": "Network request monitoring support for Bugsnag.", "homepage": "https://bugsnag.com", "license": "MIT", "authors": { "Bugsnag": "notifiers@bugsnag.com" }, - "readme": "https://raw.githubusercontent.com/bugsnag/bugsnag-cocoa/v6.16.7/BugsnagNetworkRequestPlugin/README.md", + "readme": "https://raw.githubusercontent.com/bugsnag/bugsnag-cocoa/v6.16.8/BugsnagNetworkRequestPlugin/README.md", "source": { "git": "https://github.com/bugsnag/bugsnag-cocoa.git", - "tag": "v6.16.7" + "tag": "v6.16.8" }, "dependencies": { "Bugsnag": "~> 6.13" }, "platforms": { - "ios": "9.3", + "ios": "9.0", "osx": "10.11", "tvos": "9.2" }, diff --git a/BugsnagNetworkRequestPlugin/BugsnagNetworkRequestPlugin.xcodeproj/project.pbxproj b/BugsnagNetworkRequestPlugin/BugsnagNetworkRequestPlugin.xcodeproj/project.pbxproj index 62d559507..f3a91e891 100644 --- a/BugsnagNetworkRequestPlugin/BugsnagNetworkRequestPlugin.xcodeproj/project.pbxproj +++ b/BugsnagNetworkRequestPlugin/BugsnagNetworkRequestPlugin.xcodeproj/project.pbxproj @@ -792,7 +792,6 @@ CODE_SIGN_STYLE = Automatic; DEVELOPMENT_TEAM = 372ZUL2ZB7; HEADER_SEARCH_PATHS = ../Bugsnag/include; - IPHONEOS_DEPLOYMENT_TARGET = 9.2; OTHER_LDFLAGS = "-ObjC"; PRODUCT_NAME = "$(TARGET_NAME)"; SKIP_INSTALL = YES; @@ -806,7 +805,6 @@ CODE_SIGN_STYLE = Automatic; DEVELOPMENT_TEAM = 372ZUL2ZB7; HEADER_SEARCH_PATHS = ../Bugsnag/include; - IPHONEOS_DEPLOYMENT_TARGET = 9.2; OTHER_LDFLAGS = "-ObjC"; PRODUCT_NAME = "$(TARGET_NAME)"; SKIP_INSTALL = YES; @@ -901,11 +899,13 @@ GCC_WARN_UNUSED_LABEL = YES; GCC_WARN_UNUSED_PARAMETER = YES; GCC_WARN_UNUSED_VARIABLE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 9.3; + IPHONEOS_DEPLOYMENT_TARGET = 9.0; + MACOSX_DEPLOYMENT_TARGET = 10.11; MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE; MTL_FAST_MATH = YES; ONLY_ACTIVE_ARCH = YES; SDKROOT = iphoneos; + TVOS_DEPLOYMENT_TARGET = 9.2; VERSIONING_SYSTEM = "apple-generic"; VERSION_INFO_PREFIX = ""; }; @@ -992,10 +992,12 @@ GCC_WARN_UNUSED_LABEL = YES; GCC_WARN_UNUSED_PARAMETER = YES; GCC_WARN_UNUSED_VARIABLE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 9.3; + IPHONEOS_DEPLOYMENT_TARGET = 9.0; + MACOSX_DEPLOYMENT_TARGET = 10.11; MTL_ENABLE_DEBUG_INFO = NO; MTL_FAST_MATH = YES; SDKROOT = iphoneos; + TVOS_DEPLOYMENT_TARGET = 9.2; VALIDATE_PRODUCT = YES; VERSIONING_SYSTEM = "apple-generic"; VERSION_INFO_PREFIX = ""; @@ -1013,7 +1015,6 @@ DYLIB_INSTALL_NAME_BASE = "@rpath"; INFOPLIST_FILE = BugsnagNetworkRequestPlugin/Info.plist; INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; - IPHONEOS_DEPLOYMENT_TARGET = 9.3; LD_RUNPATH_SEARCH_PATHS = ( "$(inherited)", "@executable_path/Frameworks", @@ -1037,7 +1038,6 @@ DYLIB_INSTALL_NAME_BASE = "@rpath"; INFOPLIST_FILE = BugsnagNetworkRequestPlugin/Info.plist; INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; - IPHONEOS_DEPLOYMENT_TARGET = 9.3; LD_RUNPATH_SEARCH_PATHS = ( "$(inherited)", "@executable_path/Frameworks", @@ -1107,7 +1107,6 @@ "@executable_path/../Frameworks", "@loader_path/Frameworks", ); - MACOSX_DEPLOYMENT_TARGET = 10.11; PRODUCT_BUNDLE_IDENTIFIER = com.bugsnag.BugsnagNetworkRequestPlugin; PRODUCT_NAME = BugsnagNetworkRequestPlugin; SDKROOT = macosx; @@ -1132,7 +1131,6 @@ "@executable_path/../Frameworks", "@loader_path/Frameworks", ); - MACOSX_DEPLOYMENT_TARGET = 10.11; PRODUCT_BUNDLE_IDENTIFIER = com.bugsnag.BugsnagNetworkRequestPlugin; PRODUCT_NAME = BugsnagNetworkRequestPlugin; SDKROOT = macosx; @@ -1154,7 +1152,6 @@ "@executable_path/../Frameworks", "@loader_path/../Frameworks", ); - MACOSX_DEPLOYMENT_TARGET = 10.11; PRODUCT_BUNDLE_IDENTIFIER = com.bugsnag.BugsnagNetworkRequestPluginTests; PRODUCT_NAME = "$(TARGET_NAME)"; SDKROOT = macosx; @@ -1175,7 +1172,6 @@ "@executable_path/../Frameworks", "@loader_path/../Frameworks", ); - MACOSX_DEPLOYMENT_TARGET = 10.11; PRODUCT_BUNDLE_IDENTIFIER = com.bugsnag.BugsnagNetworkRequestPluginTests; PRODUCT_NAME = "$(TARGET_NAME)"; SDKROOT = macosx; @@ -1203,7 +1199,6 @@ SDKROOT = appletvos; SKIP_INSTALL = YES; TARGETED_DEVICE_FAMILY = 3; - TVOS_DEPLOYMENT_TARGET = 9.2; }; name = Debug; }; @@ -1228,7 +1223,6 @@ SDKROOT = appletvos; SKIP_INSTALL = YES; TARGETED_DEVICE_FAMILY = 3; - TVOS_DEPLOYMENT_TARGET = 9.2; }; name = Release; }; @@ -1249,7 +1243,6 @@ PRODUCT_NAME = "$(TARGET_NAME)"; SDKROOT = appletvos; TARGETED_DEVICE_FAMILY = 3; - TVOS_DEPLOYMENT_TARGET = 9.2; }; name = Debug; }; @@ -1270,7 +1263,6 @@ PRODUCT_NAME = "$(TARGET_NAME)"; SDKROOT = appletvos; TARGETED_DEVICE_FAMILY = 3; - TVOS_DEPLOYMENT_TARGET = 9.2; }; name = Release; }; diff --git a/BugsnagNetworkRequestPlugin/README.md b/BugsnagNetworkRequestPlugin/README.md index 145ba9872..87e32945f 100644 --- a/BugsnagNetworkRequestPlugin/README.md +++ b/BugsnagNetworkRequestPlugin/README.md @@ -4,7 +4,7 @@ [![tvOS Documentation](https://img.shields.io/badge/tvos_documentation-latest-blue.svg)](https://docs.bugsnag.com/platforms/tvos/customizing-breadcrumbs/#capturing-network-requests) [![macOS Documentation](https://img.shields.io/badge/macos_documentation-latest-blue.svg)](https://docs.bugsnag.com/platforms/macos/customizing-breadcrumbs/#capturing-network-requests) -The Bugsnag crash reporter for Cocoa library automatically detects crashes and fatal signals in your iOS 9.3+, macOS 10.11+ and tvOS 9.2+ applications, collecting diagnostic information and immediately notifying your development team, helping you to understand and resolve issues as fast as possible. Learn more about [iOS crash reporting with Bugsnag](https://www.bugsnag.com/platforms/ios-crash-reporting/). +The Bugsnag crash reporter for Cocoa library automatically detects crashes and fatal signals in your iOS 9.0+, macOS 10.11+ and tvOS 9.2+ applications, collecting diagnostic information and immediately notifying your development team, helping you to understand and resolve issues as fast as possible. Learn more about [iOS crash reporting with Bugsnag](https://www.bugsnag.com/platforms/ios-crash-reporting/). **BugsnagNetworkRequestPlugin** integrates with Bugsnag to monitor network requests made via `NSURLSession` and attaches breadcrumbs to help diagnose the events leading to an error. diff --git a/CHANGELOG.md b/CHANGELOG.md index d7ce95089..bab3c3b23 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,13 @@ Changelog ========= +## 6.16.8 (2022-05-04) + +### Changes + +* Change minimum supported iOS version to 9.0. + [#1352](https://github.com/bugsnag/bugsnag-cocoa/pull/1352) + ## 6.16.7 (2022-04-13) ### Bug fixes diff --git a/Framework/Info.plist b/Framework/Info.plist index ff30ddc94..585685f86 100644 --- a/Framework/Info.plist +++ b/Framework/Info.plist @@ -15,7 +15,7 @@ CFBundlePackageType FMWK CFBundleShortVersionString - 6.16.7 + 6.16.8 CFBundleVersion 1 diff --git a/Makefile b/Makefile index b954a3cd2..9a53b510a 100644 --- a/Makefile +++ b/Makefile @@ -144,7 +144,9 @@ ifneq ($(shell git diff origin/master..master),) $(error you have unpushed commits on the master branch) endif @git tag v$(PRESET_VERSION) - @git push origin v$(PRESET_VERSION) + # Swift Package Manager prefers tags to be unprefixed package versions + @git tag $(PRESET_VERSION) + @git push origin v$(PRESET_VERSION) $(PRESET_VERSION) @git checkout next @git rebase origin/next @git merge master diff --git a/Package.swift b/Package.swift index 488052449..7567bd38f 100644 --- a/Package.swift +++ b/Package.swift @@ -6,7 +6,7 @@ let package = Package( platforms: [ .macOS(.v10_11), .tvOS("9.2"), - .iOS("9.3"), + .iOS("9.0"), ], products: [ .library(name: "Bugsnag", targets: ["Bugsnag"]), diff --git a/README.md b/README.md index ee3dea879..8600d4148 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ [![macOS Documentation](https://img.shields.io/badge/macos_documentation-latest-blue.svg)](http://docs.bugsnag.com/platforms/macos/) [![Build status](https://badge.buildkite.com/bc15523ca2dc56d1a9fd61a1c0e93b99adba62f229a1c3379b.svg?branch=master)](https://buildkite.com/bugsnag/bugsnag-cocoa) -The Bugsnag crash reporter for Cocoa library automatically detects crashes and fatal signals in your iOS 9.3+, macOS 10.11+ and tvOS 9.2+ applications, collecting diagnostic information and immediately notifying your development team, helping you to understand and resolve issues as fast as possible. Learn more about [iOS crash reporting with Bugsnag](https://www.bugsnag.com/platforms/ios-crash-reporting/). +The Bugsnag crash reporter for Cocoa library automatically detects crashes and fatal signals in your iOS 9.0+, macOS 10.11+ and tvOS 9.2+ applications, collecting diagnostic information and immediately notifying your development team, helping you to understand and resolve issues as fast as possible. Learn more about [iOS crash reporting with Bugsnag](https://www.bugsnag.com/platforms/ios-crash-reporting/). ## Features diff --git a/Tests/BugsnagTests/Info.plist b/Tests/BugsnagTests/Info.plist index 5ed1a9a84..6796a2627 100644 --- a/Tests/BugsnagTests/Info.plist +++ b/Tests/BugsnagTests/Info.plist @@ -15,7 +15,7 @@ CFBundlePackageType $(PRODUCT_BUNDLE_PACKAGE_TYPE) CFBundleShortVersionString - 6.16.7 + 6.16.8 CFBundleVersion 1 diff --git a/Tests/TestHost-iOS/Info.plist b/Tests/TestHost-iOS/Info.plist index d256c5380..e684e16eb 100644 --- a/Tests/TestHost-iOS/Info.plist +++ b/Tests/TestHost-iOS/Info.plist @@ -15,7 +15,7 @@ CFBundlePackageType $(PRODUCT_BUNDLE_PACKAGE_TYPE) CFBundleShortVersionString - 6.16.7 + 6.16.8 CFBundleVersion 1 LSRequiresIPhoneOS diff --git a/VERSION b/VERSION index e89e08cae..2b06ab849 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -6.16.7 +6.16.8 diff --git a/examples/objective-c-ios/Podfile b/examples/objective-c-ios/Podfile index 126513102..b2a7f5907 100644 --- a/examples/objective-c-ios/Podfile +++ b/examples/objective-c-ios/Podfile @@ -1,5 +1,5 @@ target 'objective-c-ios' do - platform :ios, "9.3" + platform :ios, "9.0" pod 'Bugsnag', :path => "../.." pod 'BugsnagNetworkRequestPlugin', :path => "../.." end diff --git a/examples/objective-c-ios/objective-c-ios.xcodeproj/project.pbxproj b/examples/objective-c-ios/objective-c-ios.xcodeproj/project.pbxproj index 68801342f..a913c7d0f 100644 --- a/examples/objective-c-ios/objective-c-ios.xcodeproj/project.pbxproj +++ b/examples/objective-c-ios/objective-c-ios.xcodeproj/project.pbxproj @@ -413,7 +413,7 @@ GCC_GENERATE_DEBUGGING_SYMBOLS = YES; GCC_SYMBOLS_PRIVATE_EXTERN = YES; INFOPLIST_FILE = "objective-c-ios/Info.plist"; - IPHONEOS_DEPLOYMENT_TARGET = 9.3; + IPHONEOS_DEPLOYMENT_TARGET = 9.0; PRODUCT_BUNDLE_IDENTIFIER = "com.bugsnag.examples.$(PRODUCT_NAME:rfc1034identifier)"; PRODUCT_NAME = "$(TARGET_NAME)"; PROVISIONING_PROFILE = ""; @@ -438,7 +438,7 @@ ENABLE_BITCODE = NO; GCC_GENERATE_DEBUGGING_SYMBOLS = YES; INFOPLIST_FILE = "objective-c-ios/Info.plist"; - IPHONEOS_DEPLOYMENT_TARGET = 9.3; + IPHONEOS_DEPLOYMENT_TARGET = 9.0; PRODUCT_BUNDLE_IDENTIFIER = "com.bugsnag.examples.$(PRODUCT_NAME:rfc1034identifier)"; PRODUCT_NAME = "$(TARGET_NAME)"; PROVISIONING_PROFILE = ""; diff --git a/examples/swift-ios/Podfile b/examples/swift-ios/Podfile index b2e5a2a0f..875099fd6 100644 --- a/examples/swift-ios/Podfile +++ b/examples/swift-ios/Podfile @@ -1,4 +1,4 @@ -platform :ios, '9.3' +platform :ios, '9.0' use_frameworks! target 'swift-ios' do diff --git a/examples/swift-ios/swift-ios.xcodeproj/project.pbxproj b/examples/swift-ios/swift-ios.xcodeproj/project.pbxproj index d77c1ebe4..13e6d8216 100644 --- a/examples/swift-ios/swift-ios.xcodeproj/project.pbxproj +++ b/examples/swift-ios/swift-ios.xcodeproj/project.pbxproj @@ -334,7 +334,7 @@ GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 9.3; + IPHONEOS_DEPLOYMENT_TARGET = 9.0; MTL_ENABLE_DEBUG_INFO = YES; ONLY_ACTIVE_ARCH = YES; SDKROOT = iphoneos; @@ -384,7 +384,7 @@ GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 9.3; + IPHONEOS_DEPLOYMENT_TARGET = 9.0; MTL_ENABLE_DEBUG_INFO = NO; SDKROOT = iphoneos; SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule"; @@ -403,7 +403,7 @@ DEFINES_MODULE = YES; DEVELOPMENT_TEAM = 372ZUL2ZB7; INFOPLIST_FILE = "swift-ios/Info.plist"; - IPHONEOS_DEPLOYMENT_TARGET = 9.3; + IPHONEOS_DEPLOYMENT_TARGET = 9.0; LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks"; MARKETING_VERSION = 1.1; PRODUCT_BUNDLE_IDENTIFIER = "com.bugsnag.examples.$(PRODUCT_NAME:rfc1034identifier)"; @@ -425,7 +425,7 @@ DEFINES_MODULE = YES; DEVELOPMENT_TEAM = 372ZUL2ZB7; INFOPLIST_FILE = "swift-ios/Info.plist"; - IPHONEOS_DEPLOYMENT_TARGET = 9.3; + IPHONEOS_DEPLOYMENT_TARGET = 9.0; LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks"; MARKETING_VERSION = 1.1; PRODUCT_BUNDLE_IDENTIFIER = "com.bugsnag.examples.$(PRODUCT_NAME:rfc1034identifier)"; diff --git a/features/event_callbacks.feature b/features/event_callbacks.feature index 682794781..70a11a5da 100644 --- a/features/event_callbacks.feature +++ b/features/event_callbacks.feature @@ -122,6 +122,8 @@ Feature: Callbacks can access and modify event information And I run "OnSendErrorPersistenceScenario" And I wait to receive an error And I clear the error queue + # Wait for fixture to receive the response and save the payload + And I wait for 2 seconds And I relaunch the app And I configure Bugsnag for "OnSendErrorPersistenceScenario" And I wait to receive an error diff --git a/features/fixtures/ios/iOSTestApp.xcodeproj/project.pbxproj b/features/fixtures/ios/iOSTestApp.xcodeproj/project.pbxproj index 30963441a..abd988abd 100644 --- a/features/fixtures/ios/iOSTestApp.xcodeproj/project.pbxproj +++ b/features/fixtures/ios/iOSTestApp.xcodeproj/project.pbxproj @@ -1151,7 +1151,7 @@ ../../../BugsnagNetworkRequestPlugin/BugsnagNetworkRequestPlugin/include, ); INFOPLIST_FILE = iOSTestApp/Info.plist; - IPHONEOS_DEPLOYMENT_TARGET = 9.3; + IPHONEOS_DEPLOYMENT_TARGET = 9.0; LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks"; LINKER_DISPLAYS_MANGLED_NAMES = NO; OTHER_SWIFT_FLAGS = "-Onone"; @@ -1189,7 +1189,7 @@ ../../../BugsnagNetworkRequestPlugin/BugsnagNetworkRequestPlugin/include, ); INFOPLIST_FILE = iOSTestApp/Info.plist; - IPHONEOS_DEPLOYMENT_TARGET = 9.3; + IPHONEOS_DEPLOYMENT_TARGET = 9.0; LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks"; LINKER_DISPLAYS_MANGLED_NAMES = NO; MTL_ENABLE_DEBUG_INFO = YES; diff --git a/features/fixtures/shared/scenarios/LastRunInfoScenario.swift b/features/fixtures/shared/scenarios/LastRunInfoScenario.swift index c511cca43..735bbed14 100644 --- a/features/fixtures/shared/scenarios/LastRunInfoScenario.swift +++ b/features/fixtures/shared/scenarios/LastRunInfoScenario.swift @@ -10,6 +10,7 @@ class LastRunInfoScenario: Scenario { override func startBugsnag() { config.launchDurationMillis = 0 + config.sendLaunchCrashesSynchronously = false config.addOnSendError { if let lastRunInfo = Bugsnag.lastRunInfo { $0.addMetadata( @@ -24,9 +25,29 @@ class LastRunInfoScenario: Scenario { } override func run() { + // Ensure we don't crash the fixture while the previous run's launch crash is being sent. + // Don't rely on synchronous launch crash sending because that will only wait up to 2 + // seconds, and delivery occasionally takes longer than that on BrowserStack devices. + waitForDelivery(); + if Bugsnag.lastRunInfo?.consecutiveLaunchCrashes == 3 { Bugsnag.markLaunchCompleted() } + fatalError("Oh no, the app crashed!") } + + func waitForDelivery() { + let dir = FileManager.default.urls(for: .applicationSupportDirectory, in: .userDomainMask)[0] + .appendingPathComponent("com.bugsnag.Bugsnag") + .appendingPathComponent(Bundle.main.bundleIdentifier!) + .appendingPathComponent("v1") + .appendingPathComponent("KSCrashReports") + + while try! !FileManager.default.contentsOfDirectory(at: dir, includingPropertiesForKeys: nil, options: []) + .filter({ $0.lastPathComponent.hasPrefix("CrashReport-") }).isEmpty { + NSLog("LastRunInfoScenario: waiting for delivery of crash reports...") + Thread.sleep(forTimeInterval: 0.1) + } + } }