Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish release on production profile only #134

Open
krisgerhard opened this issue Jun 9, 2023 · 2 comments
Open

Publish release on production profile only #134

krisgerhard opened this issue Jun 9, 2023 · 2 comments
Labels
backlog We hope to fix this feature/bug in the future

Comments

@krisgerhard
Copy link

Currently it appears to not be possible to upload sourcemaps conditionally for iOS.
Maybe the right question is "Why is there different logic for Android and IOS source map upload trigger?"

With Android it is possible via eas-build-on-success hook. Example:

package.json

"eas-build-on-success": "./eas-build-on-success.sh"

eas-build-on-success.sh

#!/bin/bash

if [[ "$EAS_BUILD_PROFILE" == "production" ]]; then
  echo "Production profile detected."
  npx bugsnag-eas-build-on-success
else
  echo "Non-production profile detected. Skipping hook."
fi

Due to iOS not using this hook I cannot control the conditions for publishing release & uploading sourcemaps.

Let's harmonize the logic?

@johnkiely1
Copy link
Member

Thanks for raising, we are discussing internally on the best way to approach this. We will update soon.

@johnkiely1 johnkiely1 added the needs discussion Requires internal analysis/discussion label Jun 19, 2023
@johnkiely1 johnkiely1 added backlog We hope to fix this feature/bug in the future and removed needs discussion Requires internal analysis/discussion labels Jul 4, 2023
@johnkiely1
Copy link
Member

johnkiely1 commented Jul 4, 2023

Hi @krisgerhard, we have now added something to our backlog to align approaches across both iOS and Android. We are still working on the specifics as there is some inconsistency in the Expo and RN default approaches to source map generation in different release types. We will post here with updates as we have them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We hope to fix this feature/bug in the future
Projects
None yet
Development

No branches or pull requests

2 participants